Skip to content

[$60] [Create resource] User can add resource after the phases over #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ThomasKranitsas opened this issue Apr 3, 2020 · 11 comments
Closed

Comments

@ThomasKranitsas
Copy link
Contributor

ThomasKranitsas commented Apr 3, 2020

mock/mock-challenge-api.js#40:

phases: [{
              actualStartDate: '2018-01-01',
              actualEndDate: '2019-01-01',
              phaseId: 'aa5a3f78-79e0-4bf7-93ff-b11e8f5b398b',
              isOpen: false
            }, {
              phaseId: 'cfe12b3f-2a12-4639-9d8b-ec86726f7644',
              isOpen: false
            }]

Steps to reproduce:

  • update mock to return a closed phase associated with a resource role
  • open the Postman collection
  • send requests to create ResourceRoles, ResourceRolePhaseDependencies if it is the first time
  • send the request create resource by admin

Current result(s):

  • the request is successful

Expected result(s):

  • should not allow to add resources to a finished phase

Attachments:
Untitled
Untitled2

@ThomasKranitsas
Copy link
Contributor Author

Contest https://www.topcoder.com/challenges/30121639 has been created for this ticket.

This is an automated message for thomaskranitsas via Topcoder X

@ThomasKranitsas
Copy link
Contributor Author

Contest https://www.topcoder.com/challenges/30121639 has been updated - it has been assigned to logicbreaker.

This is an automated message for thomaskranitsas via Topcoder X

@sanjiv-saini
Copy link

Getting 'Not Found',
I made the changes as suggested and ran 'npm run mock-challenge-api'.
But as can be seen inside mock-challenge-api.js#30, it is specifically checking for GET request and 'create resource by admin' is a POST request and it is getting response as 'Not Found'.

could you clear this to me?

@ThomasKranitsas
Copy link
Contributor Author

This mock API replicates the Challenge API. The fix needs to be done in the logic of this API (Resources API).

The expected logic can be found here #15

@sanjiv-saini
Copy link

@ThomasKranitsas , what should be the values of AUTH0_CLIENT_ID, and AUTH0_CLIENT_SECRET inside default.js config?

@ThomasKranitsas
Copy link
Contributor Author

@sanju-singh what's your email address? I can't paste those values here but I can email them to you.

@rashmi73
Copy link

rashmi73 commented Apr 4, 2020

@ThomasKranitsas can I give it a try if sanju singh is busy with something else?

@sanjiv-saini
Copy link

sanjiv-saini commented Apr 4, 2020

working on it, will be done in 1 hr.

@ThomasKranitsas
Copy link
Contributor Author

Great! Thanks @sanju-singh

@ThomasKranitsas
Copy link
Contributor Author

it seems like this is working as expected and the described issue is not a valid bug.
thanks @sanju-singh for looking into that

@ThomasKranitsas
Copy link
Contributor Author

Payment task has been updated: https://software.topcoder.com/review/actions/ViewProjectDetails?pid=30121639

This is an automated message for thomaskranitsas via Topcoder X

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants