Skip to content

[$60] [Create resource] User can add resource after the phases over #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
nqviet opened this issue Mar 28, 2020 · 3 comments
Closed

[$60] [Create resource] User can add resource after the phases over #17

nqviet opened this issue Mar 28, 2020 · 3 comments

Comments

@nqviet
Copy link

nqviet commented Mar 28, 2020

mock/mock-challenge-api.js#40:

phases: [{
              actualStartDate: '2018-01-01',
              actualEndDate: '2019-01-01',
              phaseId: 'aa5a3f78-79e0-4bf7-93ff-b11e8f5b398b',
              isOpen: false
            }, {
              phaseId: 'cfe12b3f-2a12-4639-9d8b-ec86726f7644',
              isOpen: false
            }]

Steps to reproduce:

  • update mock to return a closed phase associated with a resource role
  • open the Postman collection
  • send requests to create ResourceRoles, ResourceRolePhaseDependencies if it is the first time
  • send the request create resource by admin

Current result(s):

  • the request is successful

Expected result(s):

  • should not allow to add resources to a finished phase

Attachments:
Untitled
Untitled2

@ThomasKranitsas ThomasKranitsas changed the title [Create resource] User can add resource after the phases over [$60] [Create resource] User can add resource after the phases over Apr 3, 2020
@ThomasKranitsas
Copy link
Contributor

@topcoder-platform/tcxcommunity @topcoder-platform/topcodercompetitors this is open for pickup. Please create a PR against the develop branch.

@ThomasKranitsas
Copy link
Contributor

@sanju-singh please disregard the changes I'll be making on the issue. We're trying to fix Topcoder-X

@ThomasKranitsas
Copy link
Contributor

@sanju-singh I'm removing you from this one and will add you on #20 which is basically the same. It's just an issue with our task payment processor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants