Skip to content

$20 | New nav - hide white secondary menus when empty #142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kkartunov opened this issue Jun 25, 2019 · 20 comments
Closed

$20 | New nav - hide white secondary menus when empty #142

kkartunov opened this issue Jun 25, 2019 · 20 comments
Assignees
Labels

Comments

@kkartunov
Copy link
Contributor

If some of:

is empty do not show the corresponding menu element/area.

@luizrrodrigues luizrrodrigues removed their assignment Jan 9, 2020
@luizrrodrigues luizrrodrigues changed the title New nav - hide white secondary menus when empty $15 | New nav - hide white secondary menus when empty Jan 9, 2020
@rashmi73 rashmi73 self-assigned this Jan 9, 2020
@rashmi73
Copy link
Contributor

rashmi73 commented Jan 9, 2020

@luizrrodrigues any scenario where it becomes empty?

@luizrrodrigues
Copy link
Collaborator

@rashmi73 You need to edit config file:

config/default.js
config/production.js

@luizrrodrigues
Copy link
Collaborator

@rashmi73 Any status on this one?

@gets0ul gets0ul self-assigned this Jan 14, 2020
@luizrrodrigues
Copy link
Collaborator

@gets0ul Not working to subMenu:

Screen Shot 2020-01-17 at 18 59 50

Screen Shot 2020-01-17 at 18 57 28

@gets0ul
Copy link
Collaborator

gets0ul commented Jan 18, 2020

@luizrrodrigues Can you bump the prize because the original requirement was for secondaryMenu only, not including subMenu?

@gets0ul
Copy link
Collaborator

gets0ul commented Jan 18, 2020

@luizrrodrigues PR is updated.

@luizrrodrigues
Copy link
Collaborator

@gets0ul I'll check about prize.

@luizrrodrigues luizrrodrigues changed the title $15 | New nav - hide white secondary menus when empty $20 | New nav - hide white secondary menus when empty Jan 21, 2020
@luizrrodrigues
Copy link
Collaborator

@gets0ul Prize updated

@luizrrodrigues luizrrodrigues transferred this issue from topcoder-platform/community-app Jan 21, 2020
@luizrrodrigues luizrrodrigues added nav_Assigned nav_ReadyForReview P3 Normal (resolved within 7 days) labels Jan 21, 2020
@luizrrodrigues
Copy link
Collaborator

@gets0ul Need hide secondary menu and arrow from mobile too:

image

@gets0ul
Copy link
Collaborator

gets0ul commented Jan 22, 2020

@luizrrodrigues PR updated for mobile menu #105

@luizrrodrigues
Copy link
Collaborator

@gets0ul still see some issues with your approach, like still seeing arrow and in menu when submenu not exist. But based in your approach I have fixed other issues, please take a look: https://github.com/topcoder-platform/navigation-component/pull/146/files

@SathyaJayabal
Copy link
Collaborator

@luizrrodrigues @kkartunov How can we reproduce / test this issue ?

@luizrrodrigues
Copy link
Collaborator

@SathyaJayabal I'll add video verification here.

@gets0ul
Copy link
Collaborator

gets0ul commented Feb 8, 2020

@luizrrodrigues Why is it not getting into 'Paid' status?

@SathyaJayabal To test, you need to set the submenu to be empty #142 (comment)

@luizrrodrigues
Copy link
Collaborator

@gets0ul Sorry delay here, I'll provide a video to QA team pass this one.

@luizrrodrigues
Copy link
Collaborator

@SathyaJayabal
Copy link
Collaborator

@luizrrodrigues , thank you for the videos.

@SathyaJayabal
Copy link
Collaborator

@luizrrodrigues , please confirm that this cannot be verified on beta.

@SathyaJayabal SathyaJayabal added Beta Env Environment and removed Dev Env Environment labels Feb 27, 2020
@SathyaJayabal SathyaJayabal added this to the Community App 0.21.01 milestone Feb 27, 2020
@luizrrodrigues
Copy link
Collaborator

@SathyaJayabal Yes, the verification need be via local env, like shared in the video.

@SathyaJayabal
Copy link
Collaborator

Cannot be verified in production.

@SathyaJayabal SathyaJayabal added Prod Env Environment and removed Beta Env Environment labels Feb 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants