-
Notifications
You must be signed in to change notification settings - Fork 22
$20 | New nav - hide white secondary menus when empty #142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@luizrrodrigues any scenario where it becomes empty? |
@rashmi73 You need to edit config file:
|
@rashmi73 Any status on this one? |
@gets0ul Not working to |
@luizrrodrigues Can you bump the prize because the original requirement was for secondaryMenu only, not including subMenu? |
@luizrrodrigues PR is updated. |
@gets0ul I'll check about prize. |
@gets0ul Prize updated |
@gets0ul Need hide secondary menu and arrow from mobile too: |
@luizrrodrigues PR updated for mobile menu #105 |
@gets0ul still see some issues with your approach, like still seeing arrow and in menu when submenu not exist. But based in your approach I have fixed other issues, please take a look: https://github.com/topcoder-platform/navigation-component/pull/146/files |
@luizrrodrigues @kkartunov How can we reproduce / test this issue ? |
@SathyaJayabal I'll add video verification here. |
@luizrrodrigues Why is it not getting into 'Paid' status? @SathyaJayabal To test, you need to set the submenu to be empty #142 (comment) |
@gets0ul Sorry delay here, I'll provide a video to QA team pass this one. |
@luizrrodrigues , thank you for the videos. |
@luizrrodrigues , please confirm that this cannot be verified on beta. |
@SathyaJayabal Yes, the verification need be via local env, like shared in the video. |
Cannot be verified in production. |
If some of:
is empty do not show the corresponding menu element/area.
The text was updated successfully, but these errors were encountered: