Skip to content

Should "Home" be disabled inside the Onboarding flow #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
rakibansary opened this issue Nov 9, 2021 · 7 comments
Closed

Should "Home" be disabled inside the Onboarding flow #82

rakibansary opened this issue Nov 9, 2021 · 7 comments
Assignees
@nursoltan-s @Oanh-and-only-Oanh @sandhiyakavi
Labels
P1 QA Pass in Prod

Comments

@rakibansary
Copy link
Contributor

When in the onboarding flow we hide

  1. Tool Switcher
  2. Notifications Icon
  3. Profile link in the dropdown

image

Clicking the Top Left icon on the navbar will still navigate the user to https://platform.topcoder.com. Should this be disabled inside the onboarding flow?
@rakibansary rakibansary added the question Further information is requested label Nov 9, 2021
@Oanh-and-only-Oanh
Copy link

Oanh-and-only-Oanh commented Nov 9, 2021 via email

@rakibansary rakibansary added the P1 label Nov 9, 2021
@nursoltan-s
Copy link
Collaborator

topcoder-archive/topcoder-platform-mfe-header#48

@Oanh-and-only-Oanh Oanh-and-only-Oanh removed the question Further information is requested label Nov 9, 2021
@sandhiyakavi
Copy link
Collaborator

@rakibansary Now the nav bar itself is completely hided. The user won't be able to even logout of the application. Is it expected?

Also the Firstname,Lastname are not correctly displayed now
image

@rakibansary
Copy link
Contributor Author

The NavBar should be visible. I'm not seeing the reported behaviour though

image

@sandhiyakavi
Copy link
Collaborator

@rakibansary If the onboarding procedure has already reached step 4 (complete) ,the nav bar is visible.

@rakibansary
Copy link
Contributor Author

@sandhiyakavi this was an issue with navbar not rendering for users who has first name and/or last name undefined. topcoder-archive/topcoder-platform-mfe-header#51 should fix this issue.

@sandhiyakavi
Copy link
Collaborator

Verified in Prod Env. Working as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nursoltan-s nursoltan-s

@Oanh-and-only-Oanh Oanh-and-only-Oanh

@sandhiyakavi sandhiyakavi

Labels
P1 QA Pass in Prod
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@rakibansary @nursoltan-s @Oanh-and-only-Oanh @sandhiyakavi