Skip to content

Release submission issue on Challenges-App MFE #330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 3, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion build.sh
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,9 @@ UPDATE_CACHE=""

docker build -f docker/Dockerfile -t $APP_NAME:latest \
--build-arg APPMODE=$APPMODE \
--build-arg APPENV=$APPENV .
--build-arg APPENV=$APPENV \
--build-arg FILESTACK_API_KEY=$FILESTACK_API_KEY \
--build-arg FILESTACK_SUBMISSION_CONTAINER=$FILESTACK_SUBMISSION_CONTAINER .

docker create --name app $APP_NAME:latest

Expand Down
6 changes: 2 additions & 4 deletions config/dev.js
Original file line number Diff line number Diff line change
Expand Up @@ -133,11 +133,9 @@ module.exports = {
/* Filestack configuration for uploading Submissions
* These are for the development back end */
FILESTACK: {
API_KEY: process.env.FILESTACK_API_KEY || "AzFINuQoqTmqw0QEoaw9az",
API_KEY: process.env.FILESTACK_API_KEY,
REGION: "us-east-1",
SUBMISSION_CONTAINER:
process.env.FILESTACK_SUBMISSION_CONTAINER ||
"topcoder-dev-submissions-dmz",
SUBMISSION_CONTAINER: process.env.FILESTACK_SUBMISSION_CONTAINER
},
/* Time in MS to wait before refreshing challenge details after register
* and unregister. Used to allow API sufficent time to update.
Expand Down
6 changes: 2 additions & 4 deletions config/prod.js
Original file line number Diff line number Diff line change
Expand Up @@ -128,11 +128,9 @@ module.exports = {
DEFAULT_ENVIRONMENT: "master",
},
FILESTACK: {
API_KEY: process.env.FILESTACK_API_KEY || "AzFINuQoqTmqw0QEoaw9az",
API_KEY: process.env.FILESTACK_API_KEY,
REGION: "us-east-1",
SUBMISSION_CONTAINER:
process.env.FILESTACK_SUBMISSION_CONTAINER ||
"topcoder-dev-submissions-dmz",
SUBMISSION_CONTAINER: process.env.FILESTACK_SUBMISSION_CONTAINER
},
/* Time in MS to wait before refreshing challenge details after register
* and unregister. Used to allow API sufficent time to update.
Expand Down
4 changes: 4 additions & 0 deletions docker/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,13 @@ FROM node:10.22.1

ARG APPMODE
ARG APPENV
ARG FILESTACK_API_KEY
ARG FILESTACK_SUBMISSION_CONTAINER

ENV APPMODE=$APPMODE
ENV APPENV=$APPENV
ENV FILESTACK_API_KEY=$FILESTACK_API_KEY
ENV FILESTACK_SUBMISSION_CONTAINER=$FILESTACK_SUBMISSION_CONTAINER

# Copy the current directory into the Docker image
COPY . /micro-frontends-challenges-app
Expand Down
2 changes: 2 additions & 0 deletions webpack.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -116,6 +116,8 @@ module.exports = (webpackConfigEnv) => {
..._.mapValues(config, (value) => JSON.stringify(value)),
APPENV: JSON.stringify(process.env.APPENV),
APPMODE: JSON.stringify(process.env.APPMODE),
FILESTACK_API_KEY: JSON.stringify(process.env.FILESTACK_API_KEY),
FILESTACK_SUBMISSION_CONTAINER: JSON.stringify(process.env.FILESTACK_SUBMISSION_CONTAINER),
},
}),
],
Expand Down