-
Notifications
You must be signed in to change notification settings - Fork 12
[$15] Skills/Technology Filters that have the pound symbol ('#') or other special symbol disrupting normal filtering function #126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Challenge https://www.topcoder.com/challenges/3dc2f043-3957-4dbb-b557-4285e10beefb has been created for this ticket. |
@bug-bash-helper assign |
@yoution ✅ you are now assigned to this issue and have 12 hours to complete it. As soon as you are done, please, make a comment like below, including the link to the pull request:
|
Challenge https://www.topcoder.com/challenges/3dc2f043-3957-4dbb-b557-4285e10beefb has been assigned to yoution. |
@yoution ✅ you are now assigned to this issue and have 12 hours to complete it. As soon as you are done, please, make a comment like below, including the link to the pull request:
|
@bug-bash-helper #150 is ready for review |
@yoution ✅ this issue is marked as Now you may pick up another issue which is open for pickup if you like to. |
1 similar comment
@yoution ✅ this issue is marked as Now you may pick up another issue which is open for pickup if you like to. |
Challenge https://www.topcoder.com/challenges/3dc2f043-3957-4dbb-b557-4285e10beefb yoution has been unassigned. |
Fixed 🆗 bandicam.2021-11-18.09-36-49-333.mp4 |
Challenge https://www.topcoder.com/challenges/3dc2f043-3957-4dbb-b557-4285e10beefb has been assigned to yoution. |
* issue #145 * fix: issue #110 * Fixed #96 * Reset Pagination to 1 When Choosing Filter * linter * fix: issue #126 * fix: issue #106 * issue #143 * Prevent Trigger Change On Date Picker Input * fix: issue #85 * Fixes #95 * fix: issue #76 * issue #97 * ci:deploying * Add Close Button in Calendar * issue #132 * issue 132: focus selection range when having value * issue 132: fixed duration of a week having 8 days * Clear Challenge Filter On Menu Click * Reset Pagination to 1 * linter * Implement Not Found Error * Use debounce function for sort by * issue #75 * Minor update completed * Updated totalPrizesTo * issue 75: refixed * fix: issue #76 * fix: issue #85 * ci:deploying * Fixes #95 * issue #75 * issue 75: refixed * Use debounce function for sort by * issue #97 * Reset Pagination to 1 When Choosing Filter * linter * issue #145 * Implement Not Found Error * Prevent Trigger Change On Date Picker Input * issue #132 * issue 132: focus selection range when having value * issue 132: fixed duration of a week having 8 days * =resolve merge conflict * Replace Track QA * Reset Pagination * Minor updates done for fixing #96 * fix: lint * fix: refine * restore ci Co-authored-by: Nguyen Viet <[email protected]> Co-authored-by: yoution <[email protected]> Co-authored-by: Shivam Kumar Singh <[email protected]> Co-authored-by: M Fikri A <[email protected]> Co-authored-by: Nguyen Viet <[email protected]>
Double checked 🆗 bandicam.2021-11-22.14-52-09-068.mp4 |
Verified in Prod 🆗 bandicam.2021-11-23.12-07-04-532.mp4 |
Payment task has been updated: https://www.topcoder.com/challenges/3dc2f043-3957-4dbb-b557-4285e10beefb |
* issue #145 * fix: issue #110 * Fixed #96 * Reset Pagination to 1 When Choosing Filter * linter * fix: issue #126 * fix: issue #106 * issue #143 * Prevent Trigger Change On Date Picker Input * fix: issue #85 * Fixes #95 * fix: issue #76 * issue #97 * ci:deploying * Add Close Button in Calendar * issue #132 * issue 132: focus selection range when having value * issue 132: fixed duration of a week having 8 days * Clear Challenge Filter On Menu Click * Reset Pagination to 1 * linter * Implement Not Found Error * Use debounce function for sort by * issue #75 * Minor update completed * Updated totalPrizesTo * issue 75: refixed * fix: issue #76 * fix: issue #85 * ci:deploying * Fixes #95 * issue #75 * issue 75: refixed * Use debounce function for sort by * issue #97 * Reset Pagination to 1 When Choosing Filter * linter * issue #145 * Implement Not Found Error * Prevent Trigger Change On Date Picker Input * issue #132 * issue 132: focus selection range when having value * issue 132: fixed duration of a week having 8 days * =resolve merge conflict * Replace Track QA * Reset Pagination * Minor updates done for fixing #96 * fix: lint * fix: refine * restore ci * deploy bug bash * issue 91 fix (#169) * issue 91 fix * feedback fix * adjustment * restore ci * issue #115 (#183) * ci: deploying * fixed some issues (#184) * fixed issues: - detailed page navigation should not refresh the page - Joi validation of url query should return default values if not matched - missing QA track icon * fixed track -> [track] * ci: revert * issue #132: fixed focused date jump (#191) * fix lint * ci:deploying * Fix Issue 182 (#199) * Add loading indicator * update margin Co-authored-by: mfikria <[email protected]> * DO not reset challenges (#200) * <fix> issue 102: submit without registration (#197) * fix: issue 133 (#203) * <fix> issue_133 * <fix> issue_133 - code updated * revert ci * fix lint * fix:254 * issue #258 (#279) * ci: deploying challengeapp * fixed responsive (#280) * fixed responsive * fixed responsive for ipad (768px) * fixed title font size * fixed clicking mobile menu * wrap code (#286) * Issue#228 (#270) * fixes #228 * Update index.jsx for #228 * Update index.js for #228 * fix lint * clear btn * handle * fixes #226 (#290) * fix price * handle width * reset ci Co-authored-by: Nguyen Viet <[email protected]> Co-authored-by: yoution <[email protected]> Co-authored-by: Shivam Kumar Singh <[email protected]> Co-authored-by: M Fikri A <[email protected]> Co-authored-by: Nguyen Viet <[email protected]> Co-authored-by: Gaurav Seta <[email protected]> Co-authored-by: M Fikri A <[email protected]> Co-authored-by: mfikria <[email protected]> Co-authored-by: linmiao <[email protected]>
* [Bug Bash] Fix 1 (#173) * issue #145 * fix: issue #110 * Fixed #96 * Reset Pagination to 1 When Choosing Filter * linter * fix: issue #126 * fix: issue #106 * issue #143 * Prevent Trigger Change On Date Picker Input * fix: issue #85 * Fixes #95 * fix: issue #76 * issue #97 * ci:deploying * Add Close Button in Calendar * issue #132 * issue 132: focus selection range when having value * issue 132: fixed duration of a week having 8 days * Clear Challenge Filter On Menu Click * Reset Pagination to 1 * linter * Implement Not Found Error * Use debounce function for sort by * issue #75 * Minor update completed * Updated totalPrizesTo * issue 75: refixed * fix: issue #76 * fix: issue #85 * ci:deploying * Fixes #95 * issue #75 * issue 75: refixed * Use debounce function for sort by * issue #97 * Reset Pagination to 1 When Choosing Filter * linter * issue #145 * Implement Not Found Error * Prevent Trigger Change On Date Picker Input * issue #132 * issue 132: focus selection range when having value * issue 132: fixed duration of a week having 8 days * =resolve merge conflict * Replace Track QA * Reset Pagination * Minor updates done for fixing #96 * fix: lint * fix: refine * restore ci Co-authored-by: Nguyen Viet <[email protected]> Co-authored-by: yoution <[email protected]> Co-authored-by: Shivam Kumar Singh <[email protected]> Co-authored-by: M Fikri A <[email protected]> Co-authored-by: Nguyen Viet <[email protected]> * Challenges bug bash - three addition tickets (#178) Three addition bug tickets * [Bug Bash] Challenges bug bash - One more ticket (#185) * [Additional Fix] Challenges bug bash (#192) Additional fix for issue_132 * Commented out Grid View Button (#195) Co-authored-by: Pauline <[email protected]> * Revert "Commented out Grid View Button (#195)" (#196) This reverts commit c0efb7e. * [Bug Bash] Challenges bug bash - 2 (#267) * [Bug Bash] Fixign lint * fixes #254 (#275) * Revert "fixes #254 (#275)" (#282) This reverts commit 76bb2f4. * [Bug Bash] Challenges bug bash - Round 3 (#287) * issue #145 * fix: issue #110 * Fixed #96 * Reset Pagination to 1 When Choosing Filter * linter * fix: issue #126 * fix: issue #106 * issue #143 * Prevent Trigger Change On Date Picker Input * fix: issue #85 * Fixes #95 * fix: issue #76 * issue #97 * ci:deploying * Add Close Button in Calendar * issue #132 * issue 132: focus selection range when having value * issue 132: fixed duration of a week having 8 days * Clear Challenge Filter On Menu Click * Reset Pagination to 1 * linter * Implement Not Found Error * Use debounce function for sort by * issue #75 * Minor update completed * Updated totalPrizesTo * issue 75: refixed * fix: issue #76 * fix: issue #85 * ci:deploying * Fixes #95 * issue #75 * issue 75: refixed * Use debounce function for sort by * issue #97 * Reset Pagination to 1 When Choosing Filter * linter * issue #145 * Implement Not Found Error * Prevent Trigger Change On Date Picker Input * issue #132 * issue 132: focus selection range when having value * issue 132: fixed duration of a week having 8 days * =resolve merge conflict * Replace Track QA * Reset Pagination * Minor updates done for fixing #96 * fix: lint * fix: refine * restore ci * deploy bug bash * issue 91 fix (#169) * issue 91 fix * feedback fix * adjustment * restore ci * issue #115 (#183) * ci: deploying * fixed some issues (#184) * fixed issues: - detailed page navigation should not refresh the page - Joi validation of url query should return default values if not matched - missing QA track icon * fixed track -> [track] * ci: revert * issue #132: fixed focused date jump (#191) * fix lint * ci:deploying * Fix Issue 182 (#199) * Add loading indicator * update margin Co-authored-by: mfikria <[email protected]> * DO not reset challenges (#200) * <fix> issue 102: submit without registration (#197) * fix: issue 133 (#203) * <fix> issue_133 * <fix> issue_133 - code updated * revert ci * fix lint * fix:254 * issue #258 (#279) * ci: deploying challengeapp * fixed responsive (#280) * fixed responsive * fixed responsive for ipad (768px) * fixed title font size * fixed clicking mobile menu * wrap code (#286) * Issue#228 (#270) * fixes #228 * Update index.jsx for #228 * Update index.js for #228 * fix lint * clear btn * handle * fixes #226 (#290) * fix price * handle width * reset ci Co-authored-by: Nguyen Viet <[email protected]> Co-authored-by: yoution <[email protected]> Co-authored-by: Shivam Kumar Singh <[email protected]> Co-authored-by: M Fikri A <[email protected]> Co-authored-by: Nguyen Viet <[email protected]> Co-authored-by: Gaurav Seta <[email protected]> Co-authored-by: M Fikri A <[email protected]> Co-authored-by: mfikria <[email protected]> Co-authored-by: linmiao <[email protected]> * fix merge issue * [Bug Bash] Challenges bug bash - Additional Two tickets (#318) Co-authored-by: Nguyen Viet <[email protected]> Co-authored-by: yoution <[email protected]> Co-authored-by: Shivam Kumar Singh <[email protected]> Co-authored-by: M Fikri A <[email protected]> Co-authored-by: Nguyen Viet <[email protected]> Co-authored-by: pauline <[email protected]> Co-authored-by: Pauline <[email protected]> Co-authored-by: Gaurav Seta <[email protected]> Co-authored-by: M Fikri A <[email protected]> Co-authored-by: mfikria <[email protected]> Co-authored-by: linmiao <[email protected]>
Uh oh!
There was an error while loading. Please reload this page.
Summary:
Skills/Technology filters that have a pound symbol ('#') are disrupting other filters because of the way it is being passed in the URL. Skills/Technology should be able to compound by selecting multiple options so that they filter based on all of the selected skills. However, when selecting certain options (i.e. C#, F#), many or all of the selected options are removed from the list. Not only that, selecting disrupting options also unchecks the selected Challenge Types and Tracks filters and resets the the Prize Amount.
One possible reason behind this is because of how the strings found after the pound symbol in URLs are interpreted. When selecting C#, C is retained as the filter while removing every other skill and unchecking/resetting the other filters, because C exists as a valid skill filter option. However, when F# is selected, it removes all the filters altogether because there is no valid F option and is therefore not recognized as an existing filter.
Steps to Reproduce:
Actual Result:
The filters are unchecked and reset. (See screencap below) All other previously selected tags are still found in the URL but are not being filtered correctly if they're found after the pound symbol.
Expected Result:
Valid challenges should be filtered correctly. If there are no valid challenges, the filters should remain as is.
Environment Details:
Devices(s): Macbook Pro, iPhone SE 2020
Operating System and version: MacOS 11.6, iOS 15.0.2
Browser and version: Google Chrome 95.0.4638.54, Firefox 93 (64-bit)
Screen recording or Screen snapshot:
F# Example
C# Example
The text was updated successfully, but these errors were encountered: