Skip to content

Fix issues in mobile screen #365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Fix issues in mobile screen #365

wants to merge 2 commits into from

Conversation

marioskranitsas
Copy link
Collaborator

@marioskranitsas marioskranitsas commented May 19, 2022

No description provided.

@dedywahyudi
Copy link
Collaborator

@marioskranitsas Please check and fix these feedback.
Let me know for any questions

  1. Banner on the basic info page is different:
  • remove the padding left & right so the top area use full width
  1. The price and days row icons are not aligned on the basic info page
  • "?" need use green color & placed on the right side
  1. Too many spaces in Project title section/Your industry section/after ' Styles & themes' section/
  • look good
  1. The separation line is missing before ‘Your Industry’ section
  • look good
  1. Design shows 3 colors ina row but the app has only 2 in a row
  • Need reduce padding on the right side. Or make all colors centered
  1. Default text not visible in color specify field and too many spaces before it
  • need top spacing above the text. Is font size correct?
  1. The Save for later button and submit buttons deviates from the design
  • Save later need to be icon, and both save & review need to be aligned
  1. Banner on the Review and payment page is different:
  • background still look different
  1. The price and days row icons are not aligned on the Review and payment page
  • "?" need use green color & placed on the right side
  1. Alignment issue in the checkbox text on payment section
  • still not fixed, follow design to make the Understand text and Order Contact link inline
  1. There’s an outline when the colors are selected
  • look good
  1. The save for later button is not visible
  • Save for later need to be icon

STYLE & THEME

  • All boxes need centered
  • When modal window show up, modal not use full width? Content not visible

@marioskranitsas
Copy link
Collaborator Author

@dedywahyudi i think that the Save for later icon is not the correct icon on figma , can i have the correct one?
everything else is ready

@dedywahyudi
Copy link
Collaborator

@marioskranitsas This icon?

Icon-save

@marioskranitsas
Copy link
Collaborator Author

yes , is this the Save For Later icon ?

@dedywahyudi
Copy link
Collaborator

Yes, this is save later icon from Figma

@marioskranitsas
Copy link
Collaborator Author

@dedywahyudi ok , thank you

@marioskranitsas
Copy link
Collaborator Author

I cannot export the save for later icon from https://www.figma.com/file/2t8Wcyu8FAXxzQGpyK8r4f/TC-Design-System-2.0-%2F-2022?node-id=115%3A2612 as exporting is disabled. Please provide the icon file so I can fix the last issue

@marioskranitsas
Copy link
Collaborator Author

I have created a new PR here #377 as I was getting an error trying to push to this one

@dedywahyudi
Copy link
Collaborator

@marioskranitsas The svg above not works? You can download and use that save for later icon

@dedywahyudi
Copy link
Collaborator

@marioskranitsas

Latest feedback

  1. The price and days row icons are not aligned on the basic info page
  • "?" icon need use green color & placed on the right side
  1. Design shows 3 colors ina row but the app has only 2 in a row
  • Need make all colors centered
  1. The Save for later button and submit buttons deviates from the design
  • Save later need to be icon, and both save & review need to be aligned
  1. The price and days row icons are not aligned on the Review and payment page
  • "?" need use green color & placed on the right side
  1. Alignment issue in the checkbox text on payment section
  • still not fixed, follow design to make the Understand text and Order Contact link inline
  1. The save for later button is not visible
  • Save for later need to be icon

STYLE & THEME AREA

  • All boxes need centered
  • When modal window show up, modal content look cut off and not use full width? Content not visible

@ThomasKranitsas
Copy link
Contributor

@dedywahyudi just to make sure, was the review done using this PR or using #377 ?

Can we close this PR to avoid confusion?

@marioskranitsas please see the above feedback and fix the remaining issues so we can close this ticket out.

@dedywahyudi
Copy link
Collaborator

@ThomasKranitsas

Hm, i tested using this PR.

@marioskranitsas Which one that covers all mobile issue feedback?

@ThomasKranitsas
Copy link
Contributor

@dedywahyudi I thought so. Please check using this #377 one

@ThomasKranitsas
Copy link
Contributor

Refer to #365 (comment)

@marioskranitsas
Copy link
Collaborator Author

@dedywahyudi yes , Please use this #377

@dedywahyudi
Copy link
Collaborator

@ThomasKranitsas Ok, let's close this PR

@brooketopcoder brooketopcoder deleted the issue-346 branch June 1, 2022 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants