-
Notifications
You must be signed in to change notification settings - Fork 10
Fix issues in mobile screen #365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@marioskranitsas Please check and fix these feedback.
STYLE & THEME
|
@dedywahyudi i think that the Save for later icon is not the correct icon on figma , can i have the correct one? |
@marioskranitsas This icon? |
yes , is this the Save For Later icon ? |
Yes, this is save later icon from Figma |
@dedywahyudi ok , thank you |
I cannot export the save for later icon from https://www.figma.com/file/2t8Wcyu8FAXxzQGpyK8r4f/TC-Design-System-2.0-%2F-2022?node-id=115%3A2612 as exporting is disabled. Please provide the icon file so I can fix the last issue |
I have created a new PR here #377 as I was getting an error trying to push to this one |
@marioskranitsas The svg above not works? You can download and use that save for later icon |
Latest feedback
STYLE & THEME AREA
|
@dedywahyudi just to make sure, was the review done using this PR or using #377 ? Can we close this PR to avoid confusion? @marioskranitsas please see the above feedback and fix the remaining issues so we can close this ticket out. |
Hm, i tested using this PR. @marioskranitsas Which one that covers all mobile issue feedback? |
@dedywahyudi I thought so. Please check using this #377 one |
Refer to #365 (comment) |
@dedywahyudi yes , Please use this #377 |
@ThomasKranitsas Ok, let's close this PR |
No description provided.