TCA-480 - replace learn.freecodecamp.org links with the platformui links #84
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
testflyjets
approved these changes
Oct 4, 2022
brooketopcoder
approved these changes
Oct 4, 2022
There was a problem hiding this comment.
@vas3a Should we remove the external link handling from the Platform UI? I don't want anyone to think they have to maintain it if a new link type is found.
|
@brooketopcoder do you mean the url handling in |
|
@vas3a Yes, that's what I meant. I forgot that it's actually in the FCC app. |
update platform-ui urls;
|
@brooketopcoder thanks for catching that up for me! Upon removal and closer inspection to the handler, I found out that I didn't replace the urls that just started with "/learn". I replaced all urls, I think this is complete now. |
brooketopcoder
approved these changes
Oct 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-- this PR updates learn.freecodecamp.org links