Skip to content

TCA-467 - fix label for submit button #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 4, 2022
Merged

Conversation

vas3a
Copy link
Collaborator

@vas3a vas3a commented Oct 4, 2022

https://topcoder.atlassian.net/browse/TCA-467

Updates the label for the submit button for the project type challenges (eg. backend course).
Remove the "ctrl + enter" hint, as it is not listening to that. Instead it is just a simple form and by hitting enter (like in a normal form) will try to submit it. No additional hint was added as this is common sense (submitting forms by hitting enter).

@testflyjets
Copy link

@vas3a Does that fact that the code editor isn't listening for Ctrl-Enter mean it's broken? It normally does submit the code on those keystrokes (or Cmd-Enter on Mac). I'm wondering if we should alert the FCC guys to this. Your thoughts?

@vas3a
Copy link
Collaborator Author

vas3a commented Oct 4, 2022

@testflyjets @brooketopcoder No, it's not borken. I added the label myself when I updated that form but I didn't realize it's not supposed to listen for ctrl+enter.

Ctrl+enter is used in the editor only -- because enter will just create a new line, so we need a "command" key to know we need to submit.

In a form, a simple enter submits the form.

@vas3a
Copy link
Collaborator Author

vas3a commented Oct 4, 2022

To be clear. The issue in here is me adding the label that contains the "Ctrl+enter" . This is not supposed in any way to listen to ctrl+enter.

Also, on FCC they don't have 2 states for the same button. They just have "submit", and when the tests are completed, you get the "completed modal".
We removed the completed modal so I had to add a 2nd state for the same button.

@vas3a vas3a merged commit 75b419b into dev Oct 4, 2022
@vas3a vas3a deleted the TCA-467_submit-btn-label-fix branch October 4, 2022 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants