Skip to content

[$125] When the callenge is renamed, the new name is not synced in the Forum #94

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sdgun opened this issue Nov 2, 2020 · 10 comments
Closed

Comments

@sdgun
Copy link
Collaborator

sdgun commented Nov 2, 2020

Steps
Create a challenge and rename the challenge name ex- https://www.topcoder-dev.com/challenges/3d88d45b-6b1c-4da0-a02d-7f73f7642bd2
Log into forums and open that challenge's forum group https://vanilla.topcoder-dev.com/group/128
Check the name

Actual result
The new name is not reflected in the forum

Expected result
Need to sync the new name to the forum

image

image

@sdgun sdgun added bug Something isn't working Dev env P4 labels Nov 2, 2020
@jmgasper
Copy link
Collaborator

jmgasper commented Nov 2, 2020

@rootelement - What do you think about this one? Is this something we need to handle?

@rootelement
Copy link
Contributor

rootelement commented Nov 2, 2020 via email

@sdgun sdgun added P3 and removed P4 labels Nov 2, 2020
@jmgasper jmgasper changed the title When the callenge is renamed, the new name is not synced in the Forum [$75] When the callenge is renamed, the new name is not synced in the Forum Nov 2, 2020
@jmgasper
Copy link
Collaborator

jmgasper commented Nov 2, 2020

Contest https://www.topcoder.com/challenges/30148288 has been created for this ticket.

This is an automated message for ghostar via Topcoder X

@jmgasper
Copy link
Collaborator

jmgasper commented Nov 2, 2020

@atelomycterus - We can handle this through the challenge forum processor, looking at the challenge.notification.update Kafka topic. You'll get the updated challenge information as the payload. It doesn't show the previous and new value, just the updated challenge, after the update has been applied:

{
  "projectId": "16665",
  "terms": [
    {
      "id": "82a35602-57c2-4b48-a9b9-b4e133b22035",
      "roleId": "3eedd4a4-3c68-4f68-8de4-a1ca5c2055e5"
    },
    {
      "id": "82a35602-57c2-4b48-a9b9-b4e133b22035",
      "roleId": "318b9c07-079a-42d9-a81f-b96be1dc1099"
    },
    {
      "id": "b11da5cd-713f-478d-90f4-f679ef53ee95",
      "roleId": "732339e7-8e30-49d7-9198-cccf9451e221"
    },
    {
      "id": "82a35602-57c2-4b48-a9b9-b4e133b22035",
      "roleId": "ff556573-5da6-4392-b38c-08c1d7599c4a"
    },
    {
      "id": "82a35602-57c2-4b48-a9b9-b4e133b22035",
      "roleId": "d663fc84-5c37-43d1-a537-793feffb7667"
    },
    {
      "id": "82a35602-57c2-4b48-a9b9-b4e133b22035",
      "roleId": "e0544b94-6420-4afc-8f63-238eddc751b9"
    },
    {
      "id": "75d2f6bb-aadc-475e-9728-32c1dbd13655",
      "roleId": "0e9c6879-39e4-4eb6-b8df-92407890faf1"
    },
    {
      "id": "e0993b1a-abf7-45e6-8ed9-8cd0546be90b",
      "roleId": "cfe12b3f-2a24-4639-9d8b-ec86726f76bd"
    }
  ],
  "task": {
    "isTask": false,
    "isAssigned": false,
    "memberId": null
  },
  "typeId": "927abff4-7af9-4145-8ba1-577c16e64e2e",
  "legacyId": 30057433,
  "endDate": "2020-11-15T17:24:58.000Z",
  "status": "Active",
  "trackId": "9b6fc876-f4d9-4ccb-9dfd-419247628825",
  "created": "2020-10-29T05:24:59.259Z",
  "updatedBy": "TonyJ",
  "createdBy": "TonyJ",
  "name": "Justin Forum Test 60 (rename)",
  "timelineTemplateId": "7ebf1c69-f62f-4d3a-bdfb-fe9ddb56861c",
  "descriptionFormat": "HTML",
  "updated": "2020-11-02T20:13:42.457Z",
  "phases": [
    {
      "id": "66fd599f-9e0c-425b-9647-9d2013660882",
      "name": "Registration",
      "phaseId": "a93544bc-c165-4af4-b55e-18f3593b457a",
      "duration": 561600,
      "scheduledStartDate": "2020-10-30T05:24:58Z",
      "scheduledEndDate": "2020-11-05T17:24:58.000Z",
      "actualStartDate": "2020-10-30T05:24:58Z",
      "actualEndDate": "2020-11-05T17:24:58.000Z",
      "isOpen": false,
      "description": "Registration Phase"
    },
    {
      "id": "4e73a21d-c1fe-4281-ac24-9c6989116b60",
      "name": "Submission",
      "phaseId": "6950164f-3c5e-4bdc-abc8-22aaf5a1bd49",
      "duration": 561600,
      "scheduledStartDate": "2020-11-05T17:24:58.000Z",
      "scheduledEndDate": "2020-11-12T05:24:58.000Z",
      "actualStartDate": "2020-11-05T17:24:58.000Z",
      "actualEndDate": "2020-11-12T05:24:58.000Z",
      "isOpen": false,
      "predecessor": "66fd599f-9e0c-425b-9647-9d2013660882",
      "description": "Submission Phase"
    },
    {
      "id": "13b910fd-2c6c-435c-8d53-4c6ab847a4eb",
      "name": "Review",
      "phaseId": "aa5a3f78-79e0-4bf7-93ff-b11e8f5b398b",
      "duration": 172800,
      "scheduledStartDate": "2020-11-12T05:24:58.000Z",
      "scheduledEndDate": "2020-11-14T05:24:58.000Z",
      "actualStartDate": "2020-11-12T05:24:58.000Z",
      "actualEndDate": "2020-11-14T05:24:58.000Z",
      "isOpen": false,
      "predecessor": "4e73a21d-c1fe-4281-ac24-9c6989116b60",
      "description": "Review Phase"
    },
    {
      "id": "70cf2cdb-67ee-4017-821e-f5a3f67bfacc",
      "name": "Appeals",
      "phaseId": "1c24cfb3-5b0a-4dbd-b6bd-4b0dff5349c6",
      "duration": 86400,
      "scheduledStartDate": "2020-11-14T05:24:58.000Z",
      "scheduledEndDate": "2020-11-15T05:24:58.000Z",
      "actualStartDate": "2020-11-14T05:24:58.000Z",
      "actualEndDate": "2020-11-15T05:24:58.000Z",
      "isOpen": false,
      "predecessor": "13b910fd-2c6c-435c-8d53-4c6ab847a4eb",
      "description": "Appeals Phase"
    },
    {
      "id": "022de6fb-c15e-49c4-893d-23b3de8aae94",
      "name": "Appeals Response",
      "phaseId": "797a6af7-cd3f-4436-9fca-9679f773bee9",
      "duration": 43200,
      "scheduledStartDate": "2020-11-15T05:24:58.000Z",
      "scheduledEndDate": "2020-11-15T17:24:58.000Z",
      "actualStartDate": "2020-11-15T05:24:58.000Z",
      "actualEndDate": "2020-11-15T17:24:58.000Z",
      "isOpen": false,
      "predecessor": "70cf2cdb-67ee-4017-821e-f5a3f67bfacc",
      "description": "Appeals Response Phase"
    }
  ],
  "prizeSets": [
    {
      "type": "placement",
      "description": "Challenge Prizes",
      "prizes": [
        {
          "type": "USD",
          "value": 1000
        }
      ]
    },
    {
      "type": "copilot",
      "prizes": [
        {
          "type": "USD",
          "value": 50
        }
      ]
    }
  ],
  "startDate": "2020-10-30T05:24:58Z",
  "legacy": {
    "track": "DEVELOP",
    "subTrack": "CODE",
    "reviewType": "COMMUNITY",
    "forumId": 0,
    "directProjectId": 23745,
    "reviewScorecardId": 30001610,
    "isTask": false
  },
  "description": "Test spec",
  "id": "8a981624-28d7-4f05-a563-b5200f8ce246",
  "tags": [
    "Heroku"
  ],
  "discussions": [
    {
      "id": "3a40d636-1350-428e-b58d-d07c9eae53b9",
      "provider": "vanilla",
      "name": "Justin Forum Test 60 Discussion",
      "type": "challenge",
      "url": "https://vanilla.topcoder-dev.com/categories/8a981624-28d7-4f05-a563-b5200f8ce246"
    }
  ],
  "groups": [],
  "metadata": [],
  "attachments": [],
  "track": "Development",
  "type": "Challenge",
  "billingAccountId": 3
}

@jmgasper jmgasper changed the title [$75] When the callenge is renamed, the new name is not synced in the Forum [$125] When the callenge is renamed, the new name is not synced in the Forum Nov 2, 2020
@jmgasper
Copy link
Collaborator

jmgasper commented Nov 2, 2020

Contest https://www.topcoder.com/challenges/30148288 has been updated - it has been assigned to obog.

This is an automated message for ghostar via Topcoder X

@atelomycterus
Copy link
Collaborator

atelomycterus commented Nov 4, 2020

@jmgasper Please apply PRs:
topcoder-platform/challenge-forum-processor#35
topcoder-platform/forums-groups-plugin#15

Thanks!
Notes: Updating challenge name is fixed. In other words, the group name is updated. What about the discussion category name?

   "discussions": [
      {
        "id": "3a40d636-1350-428e-b58d-d07c9eae53b9",
        "provider": "vanilla",
        "name": "Justin Forum Test 60 Discussion",
        "type": "challenge",
        "url": "https://vanilla.topcoder-dev.com/categories/8a981624-28d7-4f05-a563-b5200f8ce246"
      }
    ],

image

@jmgasper
Copy link
Collaborator

jmgasper commented Nov 4, 2020

@atelomycterus - If we can rename everywhere, that would be good. Is it hard to update the discussion category name?

@atelomycterus
Copy link
Collaborator

@jmgasper Implemented. Please apply PRs:
topcoder-platform/challenge-forum-processor#37
#118

Thanks!

image

@sdgun
Copy link
Collaborator Author

sdgun commented Nov 9, 2020

This issue is fixed, the renames are reflected in the forum

@jmgasper
Copy link
Collaborator

jmgasper commented Nov 9, 2020

Payment task has been updated: https://software.topcoder.com/review/actions/ViewProjectDetails?pid=30148288

This is an automated message for ghostar via Topcoder X

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants