-
Notifications
You must be signed in to change notification settings - Fork 0
[$150] Further watch changes #593
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Challenge https://www.topcoder.com/challenges/b2a4c2b7-05ad-42fd-b3e3-a7caf9e7b9ee has been created for this ticket. |
Challenge https://www.topcoder.com/challenges/b2a4c2b7-05ad-42fd-b3e3-a7caf9e7b9ee has been assigned to obog. |
@jmgasper Implemented in PRs: #596, topcoder-platform/forums-groups-plugin#86. A few questions about watching page. The recent changes affect Watching page and Watching Count in the left menu. Previously the counting was simple. Watching Count = Count of Watched Categories (turned on manually)+ Count of Watched Discussions (turned on manually). After the last changes,
It is not entirely clear which discussions to show on Watching page. Should all watched discussions be displayed on Watching page if users are watching a category? Or should all discussions turned on manually be displayed only? |
@jmgasper Please apply PR-topcoder-platform/forums-groups-plugin#87. Thanks! |
@atelomycterus - I wonder if we can just turn off the counts on the left? If they're going to affect performance, I don't think they're necessarily that useful. I'll ask Topcoder how they want to display things |
@atelomycterus - The changes here look good. I'm going to close this out and we'll think about the counts separately. |
Payment task has been updated: https://www.topcoder.com/challenges/b2a4c2b7-05ad-42fd-b3e3-a7caf9e7b9ee |
@jmgasper Verified in Dev, works as mentioned in public forums, are we not implementing this in challenge forums? |
@sdgun - Where in the challenge forum are you not seeing it work? We can log a new ticket for that. |
@sdgun @jmgasper It is implemented for |
Sure, we can turn off the Watching count. Let's wait for a response from Topcoder. |
Verified in production. |
@atelomycterus :
Got some additional clarification on the watch stuff. Essentially they want it to work more like a "select all" button:
From @hokienick below:
For example going to this page: https://vanilla.topcoder-dev.com/categories/general-discussion
Click Parent Eyeball On
Expected behavior: All thread eyeballs turn on despite being turned on/off manually at another time
Click off one thread eyeball
Expected behavior: Parent eyeball turns off and no other eyes are affected (this currently works)
Click Parent Eyeball On Again
Same behavior as
Click Parent Eyeball On
aboveClick Parent Eyeball Off
Expected behavior: All thread eyeballs turn off despite being turned on/off manually previously.
The text was updated successfully, but these errors were encountered: