Skip to content

[$150] Further watch changes #593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jmgasper opened this issue Apr 21, 2021 · 12 comments
Closed

[$150] Further watch changes #593

jmgasper opened this issue Apr 21, 2021 · 12 comments

Comments

@jmgasper
Copy link
Collaborator

@atelomycterus :

Got some additional clarification on the watch stuff. Essentially they want it to work more like a "select all" button:

From @hokienick below:
For example going to this page: https://vanilla.topcoder-dev.com/categories/general-discussion

Click Parent Eyeball On

Expected behavior: All thread eyeballs turn on despite being turned on/off manually at another time

Click off one thread eyeball

Expected behavior: Parent eyeball turns off and no other eyes are affected (this currently works)

Click Parent Eyeball On Again

Same behavior as Click Parent Eyeball On above

Click Parent Eyeball Off

Expected behavior: All thread eyeballs turn off despite being turned on/off manually previously.

@jmgasper
Copy link
Collaborator Author

Challenge https://www.topcoder.com/challenges/b2a4c2b7-05ad-42fd-b3e3-a7caf9e7b9ee has been created for this ticket.

This is an automated message for ghostar via Topcoder X

@jmgasper
Copy link
Collaborator Author

Challenge https://www.topcoder.com/challenges/b2a4c2b7-05ad-42fd-b3e3-a7caf9e7b9ee has been assigned to obog.

This is an automated message for ghostar via Topcoder X

@atelomycterus
Copy link
Collaborator

atelomycterus commented Apr 22, 2021

@jmgasper Implemented in PRs: #596, topcoder-platform/forums-groups-plugin#86. A few questions about watching page.

The recent changes affect Watching page and Watching Count in the left menu.

Previously the counting was simple. Watching Count = Count of Watched Categories (turned on manually)+ Count of Watched Discussions (turned on manually).

After the last changes, Count of Watched Categories is calculated in the same way.

Count of Watched Discussions - becomes more complicated if users are watching a category and all discussions with the green eyeballs (or the second case: turned off one discussion). We need to update all user Profiles (update User fields in cache, update user fields in DB), etc every time after posting new discussions or user logging in.

It is not entirely clear which discussions to show on Watching page. Should all watched discussions be displayed on Watching page if users are watching a category? Or should all discussions turned on manually be displayed only?

@atelomycterus
Copy link
Collaborator

@jmgasper Please apply PR-topcoder-platform/forums-groups-plugin#87. Thanks!

@jmgasper
Copy link
Collaborator Author

@atelomycterus - I wonder if we can just turn off the counts on the left? If they're going to affect performance, I don't think they're necessarily that useful.

I'll ask Topcoder how they want to display things

@jmgasper
Copy link
Collaborator Author

@atelomycterus - The changes here look good. I'm going to close this out and we'll think about the counts separately.

@jmgasper
Copy link
Collaborator Author

Payment task has been updated: https://www.topcoder.com/challenges/b2a4c2b7-05ad-42fd-b3e3-a7caf9e7b9ee
Payments Complete
Winner: obog
Copilot: ghostar
Challenge b2a4c2b7-05ad-42fd-b3e3-a7caf9e7b9ee has been paid and closed.

This is an automated message for ghostar via Topcoder X

@sdgun
Copy link
Collaborator

sdgun commented Apr 23, 2021

@jmgasper Verified in Dev, works as mentioned in public forums, are we not implementing this in challenge forums?

@jmgasper
Copy link
Collaborator Author

@sdgun - Where in the challenge forum are you not seeing it work? We can log a new ticket for that.

@atelomycterus
Copy link
Collaborator

@sdgun @jmgasper It is implemented for Public forums only. Please see the original issue (#577 (comment)).

@atelomycterus
Copy link
Collaborator

@jmgasper

I wonder if we can just turn off the counts on the left? If they're going to affect performance, I don't think they're necessarily that useful.

Sure, we can turn off the Watching count. Let's wait for a response from Topcoder.

@sdgun
Copy link
Collaborator

sdgun commented Apr 30, 2021

Verified in production.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants