Skip to content

[$30] Watch Forum/stop watching forum tool tips are not available #544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sdgun opened this issue Apr 7, 2021 · 14 comments
Closed

[$30] Watch Forum/stop watching forum tool tips are not available #544

sdgun opened this issue Apr 7, 2021 · 14 comments

Comments

@sdgun
Copy link
Collaborator

sdgun commented Apr 7, 2021

Steps
Go to any discussion and hover over the watch icon

tool tips are not available, but according to the Marvel app Watch Forum/stop watching forum tool tips should be displayed.

image

image

@sdgun sdgun added bug Something isn't working Dev env P2 labels Apr 7, 2021
@atelomycterus
Copy link
Collaborator

@jmgasper Please apply PR-#547. Fixed.

@sdgun
Copy link
Collaborator Author

sdgun commented Apr 8, 2021

@atelomycterus The tip is not displayed at the challenge forum level.

Screencast.2021-04-08.mp4

@atelomycterus
Copy link
Collaborator

@sdgun @jmgasper Please apply PR-topcoder-platform/forums-groups-plugin#77. Thanks! I didn't push updated code for a group plugin yesterday. Sorry about that.

@sdgun sdgun added this to the 1.x - Latest release candidate milestone Apr 9, 2021
@sdgun
Copy link
Collaborator Author

sdgun commented Apr 9, 2021

@atelomycterus The wording used in challenge forum level doesn't match the tool tip shown in marvel app. Also the tool tip in the design has a black background.

This is what we are showing:
image

image

This is what marvel app has:
image

image

@atelomycterus
Copy link
Collaborator

@jmgasper

The wording used in challenge forum level doesn't match the tool tip shown in marvel app.

In the MarvelApp Watch forum/Stop watching forum is used for discussions. Is it correct?
Let me know if the same wordings should be used for discussions/groups/categories.
image

Also the tool tip in the design has a black background

Bug. I'll fix it.

@jmgasper
Copy link
Collaborator

jmgasper commented Apr 9, 2021

@atelomycterus - Ah, my bad, sorry. Yeah, if we're consistent with the MarvelApp, that's fine.

@atelomycterus
Copy link
Collaborator

@jmgasper This ticket hasn't been fixed and should be re-opened. We did not log a separate ticket for tooltips. Svg images (the eye ball icons) were imported as assets, so they had the hard-coded title attribute which were displayed as native tooltips. I fixed wordings intuitively, used Watch discussion wording for a discussion and so on.
Thanks to sdgun, she noticed that we do not match the design.

  • In MarvelApp the tooltip is styled, not a native tooltip. It can be implemented with css.
  • In MarvelApp Watch forum/Stop watching forum wording is used for discussions. Is it correct?
    This can be confusing for users. If User is only watching a discussion, he/she will not notify about other posts in the category, unless he\she is watching the category where the discussion was created.
    Let me know if the same wordings should be used for discussions/groups/categories.

@jmgasper jmgasper reopened this Apr 15, 2021
@jmgasper jmgasper changed the title Watch Forum/stop watching forum tool tips are not available [$30] Watch Forum/stop watching forum tool tips are not available Apr 15, 2021
@jmgasper
Copy link
Collaborator

@atelomycterus - My bad. Sorry.

Lets follow the wording in Marvel App for now.

@atelomycterus
Copy link
Collaborator

@jmgasper Please apply PRs:

Thanks!

Testing

Please clear browser cache before testing.

image

image

image

image

@jmgasper
Copy link
Collaborator

Challenge https://www.topcoder.com/challenges/a4c211cf-a191-48a6-8a76-c501981e09c0 has been created for this ticket.

This is an automated message for ghostar via Topcoder X

@jmgasper
Copy link
Collaborator

Challenge https://www.topcoder.com/challenges/a4c211cf-a191-48a6-8a76-c501981e09c0 has been assigned to obog.

This is an automated message for ghostar via Topcoder X

@jmgasper
Copy link
Collaborator

Payment task has been updated: https://www.topcoder.com/challenges/a4c211cf-a191-48a6-8a76-c501981e09c0
Payments Complete
Winner: obog
Copilot: ghostar
Challenge a4c211cf-a191-48a6-8a76-c501981e09c0 has been paid and closed.

This is an automated message for ghostar via Topcoder X

@sdgun
Copy link
Collaborator Author

sdgun commented Apr 26, 2021

Verified in Dev.

image

image

@sdgun
Copy link
Collaborator Author

sdgun commented Apr 30, 2021

Verified in production.

image

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants