-
Notifications
You must be signed in to change notification settings - Fork 0
[$400] Watch functionality change #479
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Challenge https://www.topcoder.com/challenges/b27236ad-f253-4255-98d5-30112e167917 has been created for this ticket. |
Challenge https://www.topcoder.com/challenges/b27236ad-f253-4255-98d5-30112e167917 has been assigned to obog. |
@jmgasper A few questions Issue 1 Issue 2
Not correct. Bookmarks are used for a thread (discussion). User can bookmark a discussion. If new comments are added to the thread(discussion) then user receives email notifications. Questions
I've looked at Marvel App. The If you want to keep the bookmark feature. Please let me know if watched discussions and watched categories should be displayed in the 'Watching' screen ( https://marvelapp.com/prototype/c06bg41/screen/77911789) I've looked at 'My watches' in the old forum. Users could watch threads(discussions) and categories. I think in general our goal is to do something like it was before: |
@atelomycterus - Yeah, we want to just have a single icon that covers both bookmarking and watching. And yes, the goal is to have watches shown for threads and categories / forums. |
@jmgasper Could you ask a designer to export an eyeball icon? The designer sets which assets to make available at various resolutions and formats (SVG, etc) when syncing designs to Marvel. Thanks! Some assets (search icon and others) are available for downloading as svg format but the eyeball icon is not available: |
@atelomycterus - I've asked the Studio designer. Should have that shortly, thanks. |
@atelomycterus - From the Studio designer: https://marvelapp.com/prototype/c06bg41/screen/77911785/handoff
|
@jmgasper Thanks! A few questions: What about pagination in Watching page? On the other hand, using two paging controls for two sections (watched categories and watched discussions) overloads the page. I've added the Categories/Discussions title on Watching page. The styles for categories and discussions are similar and difficult to distinguish. The sort is applied for both sections. TODO
|
@atelomycterus - I'm fine doing whatever makes sense from a performance standpoint. Performance is the biggest priority, so we can work around that. If we can reduce what's shown on the watch screen in terms of comment / view count, that would also be fine, if it helps with performance. |
@jmgasper Please apply PRs: Thanks! TestingPlease clear browser cache before testing. |
@atelomycterus - Thanks for that. Note that I may delay merging this until tomorrow - we're doing a prod deploy today and I don't want to suck this up into that until we've had a chance to test fully. |
@jmgasper Sure, that's fine. Thanks! |
Payment task has been updated: https://www.topcoder.com/challenges/b27236ad-f253-4255-98d5-30112e167917 |
Verified in Dev. checked the below scenarios:
|
Verified in production, implemented as expected. One open issue in dev related to this (#544) |
Uh oh!
There was an error while loading. Please reload this page.
From Topcoder:
Issue 1
A few things we noticed from some of the tickets we received about this particular topic. Once again we have the triple dots and only one option. When you click on Watch nothing happens. You don’t notice a change until you click the three dots again and realize it now says “unwatch”.
Issue 2
Current Behavior: user can select discussion to Watch. There’s no frontend UI/UX changes that show user is “watching” a thread.
Requested changes
Expected behavior: Remove “Bookmark” feature and side bucket. Instead add “WATCHING” side bucket. Once user selects to “watch” a thread, the eyeball icon should change and thread should be added to the side bucket category of “Watching”.
See design:
The text was updated successfully, but these errors were encountered: