Skip to content

[$400] Watch functionality change #479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jmgasper opened this issue Mar 23, 2021 · 15 comments
Closed

[$400] Watch functionality change #479

jmgasper opened this issue Mar 23, 2021 · 15 comments

Comments

@jmgasper
Copy link
Collaborator

jmgasper commented Mar 23, 2021

From Topcoder:

Issue 1

A few things we noticed from some of the tickets we received about this particular topic. Once again we have the triple dots and only one option. When you click on Watch nothing happens. You don’t notice a change until you click the three dots again and realize it now says “unwatch”.

Screen Shot 2021-03-23 at 5 54 15 pm

Issue 2

Current Behavior: user can select discussion to Watch. There’s no frontend UI/UX changes that show user is “watching” a thread.

Requested changes

Expected behavior: Remove “Bookmark” feature and side bucket. Instead add “WATCHING” side bucket. Once user selects to “watch” a thread, the eyeball icon should change and thread should be added to the side bucket category of “Watching”.

See design:

@jmgasper
Copy link
Collaborator Author

Challenge https://www.topcoder.com/challenges/b27236ad-f253-4255-98d5-30112e167917 has been created for this ticket.

This is an automated message for ghostar via Topcoder X

@jmgasper
Copy link
Collaborator Author

Challenge https://www.topcoder.com/challenges/b27236ad-f253-4255-98d5-30112e167917 has been assigned to obog.

This is an automated message for ghostar via Topcoder X

@atelomycterus
Copy link
Collaborator

@jmgasper A few questions

Issue 1
Ok, no questions. The goal is that there will be no 3 dot menu for normal users => replace it with the eyeball icon.
image

Issue 2

Current Behavior: user can select discussion to Watch. There’s no frontend UI/UX changes that show user is “watching” a thread.

Not correct. Bookmarks are used for a thread (discussion). User can bookmark a discussion. If new comments are added to the thread(discussion) then user receives email notifications.
image

Questions

Expected behavior: Remove “Bookmark” feature and side bucket. Instead add “WATCHING” side bucket. Once user selects to “watch” a thread, the eyeball icon should change and thread should be added to the side bucket category of “Watching”.

I've looked at Marvel App. The eyeball icon is used everywhere, i.e. for categories and for discussions. So I think we need to
replace the bookmark icon with the eyeball icon, not remove “Bookmark” feature. 'watch/unwatched' should be replaced with the eyeball icon for the categories. Please correct me if I am wrong.

If you want to keep the bookmark feature. Please let me know if watched discussions and watched categories should be displayed in the 'Watching' screen ( https://marvelapp.com/prototype/c06bg41/screen/77911789)

I've looked at 'My watches' in the old forum. Users could watch threads(discussions) and categories. I think in general our goal is to do something like it was before:
image

@jmgasper
Copy link
Collaborator Author

@atelomycterus - Yeah, we want to just have a single icon that covers both bookmarking and watching. And yes, the goal is to have watches shown for threads and categories / forums.

@atelomycterus
Copy link
Collaborator

atelomycterus commented Mar 30, 2021

@jmgasper Could you ask a designer to export an eyeball icon? The designer sets which assets to make available at various resolutions and formats (SVG, etc) when syncing designs to Marvel. Thanks!

Some assets (search icon and others) are available for downloading as svg format but the eyeball icon is not available:
image

Example: search icon
image

@jmgasper
Copy link
Collaborator Author

@atelomycterus - I've asked the Studio designer. Should have that shortly, thanks.

@jmgasper
Copy link
Collaborator Author

@atelomycterus - From the Studio designer:

https://marvelapp.com/prototype/c06bg41/screen/77911785/handoff

I’ve just marked for export the watch icons for that page

@atelomycterus
Copy link
Collaborator

@jmgasper Thanks! A few questions: What about pagination in Watching page?
In the old forum the 'Watches on content that hasn't been updated for more than 90 days will be automatically removed from your list' is displayed.
Now submitters automatically watch 3 categories for development challenges. The number of records over time will be several hundred/thousand. It may be necessary to do the same in Vanilla too.

On the other hand, using two paging controls for two sections (watched categories and watched discussions) overloads the page.

I've added the Categories/Discussions title on Watching page. The styles for categories and discussions are similar and difficult to distinguish. The sort is applied for both sections.
image

Other pages:
image

image

TODO

  1. Dynamically update the count of watching in the menu.
    Add an user field to the table in order not to recalculate the number of watched categories with each request.
    Total count of watching = count of watched discussions + count of watched categories.
    Now count of watched discussions are displayed only.
  2. Fix the watching icon with the eye ball one.
    I'm going to push the code tomorrow.

@jmgasper
Copy link
Collaborator Author

@atelomycterus - I'm fine doing whatever makes sense from a performance standpoint. Performance is the biggest priority, so we can work around that. If we can reduce what's shown on the watch screen in terms of comment / view count, that would also be fine, if it helps with performance.

@atelomycterus
Copy link
Collaborator

@jmgasper Please apply PRs:
#513
topcoder-platform/forums-groups-plugin#74
topcoder-platform/forums-plugins#78

Thanks!

Testing

Please clear browser cache before testing.

Watching page:
image

Discussions page:
image

Groups page:
image

Group page:
image

Discussion page:
image

@jmgasper
Copy link
Collaborator Author

@atelomycterus - Thanks for that. Note that I may delay merging this until tomorrow - we're doing a prod deploy today and I don't want to suck this up into that until we've had a chance to test fully.

@atelomycterus
Copy link
Collaborator

@jmgasper Sure, that's fine. Thanks!

@jmgasper jmgasper changed the title [$300] Watch functionality change [$400] Watch functionality change Apr 1, 2021
@jmgasper jmgasper closed this as completed Apr 1, 2021
@jmgasper
Copy link
Collaborator Author

jmgasper commented Apr 1, 2021

Payment task has been updated: https://www.topcoder.com/challenges/b27236ad-f253-4255-98d5-30112e167917
Payments Complete
Winner: obog
Copilot: ghostar
Challenge b27236ad-f253-4255-98d5-30112e167917 has been paid and closed.

This is an automated message for ghostar via Topcoder X

@sdgun
Copy link
Collaborator

sdgun commented Apr 7, 2021

Verified in Dev.

checked the below scenarios:

  • Watching list from normal/copilot/manager user
  • Unwatching from normal/copilot/manager user
  • watching after unregistering - normal users
  • watching counts

@sdgun sdgun added this to the 1.x milestone Apr 7, 2021
@sdgun
Copy link
Collaborator

sdgun commented Apr 9, 2021

Verified in production, implemented as expected. One open issue in dev related to this (#544)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants