Skip to content

[$600] New feature for up / down votes on posts #475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jmgasper opened this issue Mar 23, 2021 · 15 comments
Closed

[$600] New feature for up / down votes on posts #475

jmgasper opened this issue Mar 23, 2021 · 15 comments

Comments

@jmgasper
Copy link
Collaborator

Screen Shot 2021-03-23 at 5 40 50 pm

@atelomycterus - Topcoder used to have up / down voting on comments, in the old forums. They'd like to have the same functionality in this new forum, where members / copilots / admins can up / down vote a comment.

The goal is to determine which comments and discussions are highly up voted, and also highly downvoted.

What we'll need:

  1. Up / down functionality added to the Topcoder plugin and displayed on discussions
  2. A new piece in the admin dashboard to view discussions / comments by votes

A single user should only be able to up vote or down vote a comment. If they have already made a choice and click it again (like "up vote"), then their initial vote should be cancelled.

This should get us started. Let me know if you have any questions on specifics on how this should work.

Relevant UI:

@jmgasper
Copy link
Collaborator Author

Challenge https://www.topcoder.com/challenges/7436b62f-63c3-4d39-90bc-d92539b37049 has been created for this ticket.

This is an automated message for ghostar via Topcoder X

@jmgasper
Copy link
Collaborator Author

Challenge https://www.topcoder.com/challenges/7436b62f-63c3-4d39-90bc-d92539b37049 has been assigned to obog.

This is an automated message for ghostar via Topcoder X

@atelomycterus
Copy link
Collaborator

@jmgasper The main requirements are clear. Thanks!

@atelomycterus
Copy link
Collaborator

@jmgasper I am working on #475 as discussed via email. Let me know if the priorities of the tasks have changed.

@jmgasper
Copy link
Collaborator Author

jmgasper commented Apr 9, 2021

@atelomycterus - The priority is #558 and then this one, thanks! I've reached out to Topcoder to make sure they're done making changes to the MarvelApp before we move on the ones you logged, thanks.

@atelomycterus
Copy link
Collaborator

@jmgasper Ok. Thanks!

@atelomycterus
Copy link
Collaborator

@jmgasper Could you ask a designer to export icons (https://marvelapp.com/prototype/c06bg41/screen/77911792)?

image

Thanks!

@atelomycterus
Copy link
Collaborator

@jmgasper The current status

Up / down functionality added to the Topcoder plugin and displayed on discussions

Need to fix the icons only.
image

A new piece in the admin dashboard to view discussions / comments by vote

I'm going to implement it tomorrow and push it in the repo.

@jmgasper
Copy link
Collaborator Author

@atelomycterus - Sounds good, thanks. I've asked our designer to provide the icons.

@atelomycterus
Copy link
Collaborator

@jmgasper I think sdgun can test it. I'll update the icons when our designer provides them.

Please apply PRs:

Thanks!

Voting

Discussions/Comments with votes are only displayed. Please let me know if you need to add/remove data.

image

image

@jmgasper
Copy link
Collaborator Author

@atelomycterus - Great, thanks!

Here's the update from the designer:

I have marked the thumbs for export on this page https://marvelapp.com/prototype/c06bg41/screen/77911792/handoff and I also showed the upvote/ downvote states at the same time

@sdgun
Copy link
Collaborator

sdgun commented Apr 12, 2021

@atelomycterus

  1. If a voted comment/discussion is deleted, getting below error while accessing the voting.

image

  1. In the Marvel app I see both upvotes and downvotes separated by a slash, but in the implementation we only show one at a time
    image

  2. Also observed an issue when one user up/down vote on a comment/discussion and then do the opposite(upvote if downvoted by the previous user and vise versa) the count still remains 0

Screencast.2021-04-12.mp4
  1. Another issue noticed during testing: the counts are incorrectly updating, for ex-when click on up vote, it shows -1
Screencast.2021-04-12.mp4
Screencast.2021-04-12.mp4
Screencast.2021-04-12.mp4

@atelomycterus
Copy link
Collaborator

atelomycterus commented Apr 12, 2021

@sdgun Thanks! The Voting control looks different on screens. I looked at this screen ((https://marvelapp.com/prototype/c06bg41/screen/77911793) and thought Topcoder made voting easier:
image

I've fixed it.

Changes

Please clear browser cache before testing.
Up and down votes are counted separately. I've cleared the previous votes on DEV. It will be easier to verify.

Fixed the icons. '-0' is not displayed according to MarvelApp.
image

Updated Voting Discussions/Comments pages:
image

@jmgasper
Please apply PRs:
topcoder-platform/forums-plugins#87
#566
Thanks!

@jmgasper
Copy link
Collaborator Author

Payment task has been updated: https://www.topcoder.com/challenges/7436b62f-63c3-4d39-90bc-d92539b37049
Payments Complete
Winner: obog
Copilot: ghostar
Challenge 7436b62f-63c3-4d39-90bc-d92539b37049 has been paid and closed.

This is an automated message for ghostar via Topcoder X

@sdgun
Copy link
Collaborator

sdgun commented Apr 18, 2021

Verified in production.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants