Skip to content

[$75] Issues with mentions #433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sdgun opened this issue Feb 24, 2021 · 6 comments
Closed

[$75] Issues with mentions #433

sdgun opened this issue Feb 24, 2021 · 6 comments

Comments

@sdgun
Copy link
Collaborator

sdgun commented Feb 24, 2021

When there is '-', '@' or space in the handle names they don't work.
Also if user do backspace after entering a space or '-', it will not show up the list of handles even if user starts typing again.

Screencast.2021-02-24.mp4
@sdgun sdgun added bug Something isn't working P3 Dev env labels Feb 24, 2021
@jmgasper jmgasper changed the title Issues with mentions [$40] Issues with mentions Feb 24, 2021
@jmgasper
Copy link
Collaborator

Challenge https://www.topcoder.com/challenges/cb0730bf-ead2-4f85-b553-7c33b3b96883 has been created for this ticket.

This is an automated message for ghostar via Topcoder X

@jmgasper
Copy link
Collaborator

Challenge https://www.topcoder.com/challenges/cb0730bf-ead2-4f85-b553-7c33b3b96883 has been assigned to obog.

This is an automated message for ghostar via Topcoder X

@atelomycterus
Copy link
Collaborator

@jmgasper Please apply PR-topcoder-platform/forums-topcoder-editor-plugin#15.

Changes

I've checked on Topcoder sign up page which chars are supported in usernames. Added missing supported chars. Username: letters, numbers and the following characters: "_", ".", "+", "-":

image

Spaces

Using a space in useranme would cause user to use a reserved/custom keyboard shortcut or use a mouse to cancel the autocompletion mode if they don't want to select. Enter confirms the selection, space (and other chars like ', ' , '(') cancels autocompletion mode.

Using '.', '+'

Using '.', '+' in "/members/autocomplete" (Topocder APIv5):

// custom filter & sort
let regex = new RegExp(`^${query.term}`, `i`);

https://github.com/topcoder-platform/member-api/blob/3474f96ff21e1c36a3964b5ba11acc93554fe9db/docs/swagger.yaml#L573
https://github.com/topcoder-platform/member-api/blob/3474f96ff21e1c36a3964b5ba11acc93554fe9db/src/services/SearchService.js#L138

'.'/'+' is used as any char:
image

@jmgasper jmgasper changed the title [$40] Issues with mentions [$75] Issues with mentions Feb 24, 2021
@jmgasper
Copy link
Collaborator

Payment task has been updated: https://www.topcoder.com/challenges/cb0730bf-ead2-4f85-b553-7c33b3b96883
Payments Complete
Winner: obog
Copilot: ghostar
Challenge cb0730bf-ead2-4f85-b553-7c33b3b96883 has been paid and closed.

This is an automated message for ghostar via Topcoder X

@sdgun
Copy link
Collaborator Author

sdgun commented Feb 25, 2021

Verified in Dev.

@sdgun sdgun added this to the V1.X milestone Feb 25, 2021
@sdgun
Copy link
Collaborator Author

sdgun commented Mar 16, 2021

Verified in production.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants