Skip to content

[$75] Handles with "." in the name does not display correctly #427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
hokienick opened this issue Feb 22, 2021 · 13 comments
Closed

[$75] Handles with "." in the name does not display correctly #427

hokienick opened this issue Feb 22, 2021 · 13 comments

Comments

@hokienick
Copy link

Part 1
If I @ someone like kiril.kartunov in a post, and if I type slow enough, I can choose his handle from the list. However once I type "." the list goes away, which doesn't help when I am typing normally.

Part 2
Even after choosing his name, once posted the tag doesn't appear correct visually:

Screen Shot 2021-02-22 at 7 48 14 AM

@sdgun
Copy link
Collaborator

sdgun commented Feb 22, 2021

@hokienick As per the current implementation, when username includes special characters, have to use double-quotes. Please refer comment #361 (comment)

@jmgasper jmgasper changed the title Handles with "." in the name does not display correctly [$75] Handles with "." in the name does not display correctly Feb 22, 2021
@jmgasper
Copy link
Collaborator

Challenge https://www.topcoder.com/challenges/57fe90f0-cd3d-4420-8963-b8fb960dccfb has been created for this ticket.

This is an automated message for ghostar via Topcoder X

@jmgasper
Copy link
Collaborator

@atelomycterus - Lower priority, but can we automate this a bit? If the user selects a handle with a . from the list - can we automatically add the "?

@jmgasper
Copy link
Collaborator

Challenge https://www.topcoder.com/challenges/57fe90f0-cd3d-4420-8963-b8fb960dccfb has been assigned to obog.

This is an automated message for ghostar via Topcoder X

@atelomycterus
Copy link
Collaborator

@jmgasper
Copy link
Collaborator

@atelomycterus - Strange - that should be deployed in prod. Any reason why it wouldn't have worked for @hokienick ?

@jmgasper
Copy link
Collaborator

Could it be because there is an @kiril and an @kiril.kartunov?

@atelomycterus
Copy link
Collaborator

atelomycterus commented Feb 23, 2021

@jmgasper Yes, I see. If user types with '.':

However once I type "." the list goes away, which doesn't help when I am typing normally.

427-2021-02-23.09-06-28.mp4

@jmgasper
Copy link
Collaborator

@atelomycterus - Ok, good note, thanks. Can we fix that?

@atelomycterus
Copy link
Collaborator

@jmgasper Sure. Please apply PR - topcoder-platform/forums-topcoder-editor-plugin#13. Thanks!

@jmgasper
Copy link
Collaborator

Payment task has been updated: https://www.topcoder.com/challenges/57fe90f0-cd3d-4420-8963-b8fb960dccfb
Payments Complete
Winner: obog
Copilot: ghostar
Challenge 57fe90f0-cd3d-4420-8963-b8fb960dccfb has been paid and closed.

This is an automated message for ghostar via Topcoder X

@sdgun
Copy link
Collaborator

sdgun commented Feb 24, 2021

Verified in Dev, this mentioned issue with '.' is fixed, but found the below issues.

#433

@lakshmiathreya lakshmiathreya added this to the V1.2 Roundtables milestone Feb 24, 2021
@sdgun sdgun modified the milestones: V1.2 Roundtables, V1.X Feb 25, 2021
@sdgun
Copy link
Collaborator

sdgun commented Mar 16, 2021

Verified in production.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants