Skip to content

[$75] Reply option is not available #425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sdgun opened this issue Feb 22, 2021 · 31 comments
Closed

[$75] Reply option is not available #425

sdgun opened this issue Feb 22, 2021 · 31 comments

Comments

@sdgun
Copy link
Collaborator

sdgun commented Feb 22, 2021

Steps
Go to any roundtable or challenge forum comment
Click on ellipsis

Reply option is not available

image

@sdgun sdgun added bug Something isn't working Dev env P0 Prod Env labels Feb 22, 2021
@jmgasper jmgasper changed the title Reply option is not available [$40] Reply option is not available Feb 22, 2021
@jmgasper
Copy link
Collaborator

Challenge https://www.topcoder.com/challenges/871248f5-5a80-44f0-a363-9ec979abb843 has been created for this ticket.

This is an automated message for ghostar via Topcoder X

@jmgasper
Copy link
Collaborator

Challenge https://www.topcoder.com/challenges/871248f5-5a80-44f0-a363-9ec979abb843 has been assigned to obog.

This is an automated message for ghostar via Topcoder X

@sdgun
Copy link
Collaborator Author

sdgun commented Feb 22, 2021

I also notice in production this is all the options I see on challenge discussions:

image

But in Dev I see all below:

image

@rootelement
Copy link
Contributor

@atelomycterus are you available? not sure what the problem is here?

@atelomycterus
Copy link
Collaborator

@rootelement I'll have look at it in 5-10 mins. I am working on #422 (user can't see some challenge discussions),
I've already figured out what happened.

@rootelement
Copy link
Contributor

Ok, please tag me on any commits so we can push to prod. These are blocking in prod

@atelomycterus
Copy link
Collaborator

@rootelement Ok

@lakshmiathreya
Copy link

@rootelement - there is no time for QA - would rely on your review for the direct Prod push ...

@atelomycterus
Copy link
Collaborator

@rootelement no changes in code, need to configure permissions.

  1. Reply is missing. Need to check/configure permissions in PROD:
    image

2.Need check/configure permissions in PROD.

@rootelement
Copy link
Contributor

I'm sorry i don't understand, you need me to check permissions in prod? Where?

@atelomycterus
Copy link
Collaborator

@rootelement Unfortunately, I don't have permissions to configure it in PROD. @jmgasper configured some permissions today in PROD.
I'm checking permissions for Copilot roles in DEV.

@rootelement
Copy link
Contributor

What is your username in prod? I'll grant temporary access so you can help us fix this P0

@atelomycterus
Copy link
Collaborator

@rootelement use obog

@rootelement
Copy link
Contributor

I've added you as Vanilla Admin in prod @atelomycterus

@atelomycterus
Copy link
Collaborator

@rootelement I have access now. Thanks!

@sushilshinde
Copy link
Collaborator

@rootelement can you also add me, send me admin url

@atelomycterus
Copy link
Collaborator

@rootelement The permissions for PROD are configured differently than for the DEV. I am reviewing all permissions.

@rootelement
Copy link
Contributor

@sushilshinde you should have it. it's based on Topcoder roles for tc users. Go to discussions.topcoder.com, click your avatar in the top right corner, and you should see Dashboard.

@atelomycterus
Copy link
Collaborator

@rootelement I've fixed copilot and Connect Copilot roles. I am checking why 'Reply' button is missing

@atelomycterus
Copy link
Collaborator

@rootelement 'Reply' button is also missing in DEV. I'll debug it in DEV. This is not critical because user can post comments.
You can revoke admin permissions.

@rootelement
Copy link
Contributor

i'll leave until the reply button is fixed just in case. But thank you

@atelomycterus
Copy link
Collaborator

@rootelement Fixed displaying Reply. PR - topcoder-platform/forums-plugins#62.

Testing

if user has Comment.Add permission for a category then 'Reply' should be displayed:
image

@atelomycterus
Copy link
Collaborator

@jmgasper Summary:

  1. I've fixed copilot and Connect Copilot roles ([$75] Reply option is not available  #425 (comment)) for 'Challenge discussions' category in PROD.
  2. 'Reply' button is missing => Please apply PR ☝️

@rootelement
Copy link
Contributor

I see this in prod. @sushilshinde and @sdgun please retest
Screen Shot 2021-02-22 at 12 33 15 PM

@jmgasper jmgasper changed the title [$40] Reply option is not available [$75] Reply option is not available Feb 22, 2021
@jmgasper
Copy link
Collaborator

Payment task has been updated: https://www.topcoder.com/challenges/871248f5-5a80-44f0-a363-9ec979abb843
Payments Complete
Winner: obog
Copilot: ghostar
Challenge 871248f5-5a80-44f0-a363-9ec979abb843 has been paid and closed.

This is an automated message for ghostar via Topcoder X

@sdgun
Copy link
Collaborator Author

sdgun commented Feb 23, 2021

Verified in production in both roundtables and challenge forums from copilot user and normal user. Reply is available and working as expected. The other missing options for the copilot are also available now.

Copilot:

image

image

Normal user:

image

@sdgun
Copy link
Collaborator Author

sdgun commented Feb 23, 2021

@jmgasper FYI Reply is not available for comments for all users in Dev, also delete discussion not available for the copilot in Dev

No reply:
image

No delete:
image

@jmgasper
Copy link
Collaborator

@sdgun - Fixed in dev. Copilots should only be able to announce or move - not edit or delete other member's comments.

@sdgun
Copy link
Collaborator Author

sdgun commented Feb 23, 2021

@jmgasper Copilot sees the Edit on challenges, but when tries to do a change and Save, see the below:

Screencast.2021-02-23.mp4

@sdgun
Copy link
Collaborator Author

sdgun commented Feb 23, 2021

@jmgasper One more thing, these options we can only see through Home >> CHALLENGE DISCUSSIONS. When access the challenges from Roundtables >> CHALLENGE DISCUSSIONS, the ellipsis is not available.

image

image

Screencast.mp4

@jmgasper
Copy link
Collaborator

@sdgun - Yes, that's acceptable. Copilots have more permissions on challenge discussions than in the roundtables.

@sdgun sdgun added the QA Pass label Feb 24, 2021
@lakshmiathreya lakshmiathreya added this to the V1.2 Roundtables milestone Feb 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants