[$300] Notification email template and documents

[jmgasper]

@atelomycterus - The notification email handles image attachment alright, but we need to expand and test documents, like .txt, .doc, and .pdf. Can those be tested / added as well please?

[jmgasper]

Contest https://www.topcoder.com/challenges/30152312 has been created for this ticket.

This is an automated message for ghostar via Topcoder X

[jmgasper]

Contest https://www.topcoder.com/challenges/30152312 has been updated - it has been assigned to obog.

This is an automated message for ghostar via Topcoder X

[atelomycterus]

@jmgasper Need more fixes with this plugin.
The editor plugin stores media data (filename, file path and so on) in Media table.
The previous plugin stores it as a part of its body. So the discussion body is formatted from Rich to Html and attachments are displayed in emails.

What issues with the editor plugin

User clicks on New discussion button and uploads files. At this moment discussionID is undefined because User hasn't clicked on post button. The editor plugin stores media data in the Media table but these records don't have discussionID yet.
DiscussionID is known after firing 'afterDiscussionSave' event in DiscussionModel. Then 'beforeRecordAdvancedNotification' event is fired. This event is used to build our email template.

The discussion save method fires the next events:

• BeforeSaveDiscussion
• AfterValidateDiscussion
• AfterSaveDiscussion
  ... other events
• BeforeRecordAdvancedNotification

There is no guarantee that the Editor plugin method handles 'AfterDiscussionSave' event (updates Media tables with the DiscussionID) before sending the email ('BeforeRecordAdvancedNotification' ). With the current implementation it is impossible to control the order of events and find out when processing is completed, because processing occurs asynchronously.

In my local env all notification events are processed earlier. Selecting all attachments by DiscussionID from Media table doesn't return data because the Media table has not been updated yet.

Need to guarantee that records are updated with discussionID in Media before sending any notifications. The same issues with comment notifications.
DiscussionModel/CommentModel + Editor Plugin should be fixed.

Let me know what is the priority of the task.

[jmgasper]

@atelomycterus - Ok, this should be relatively high priority. I'll bump the payment.

[atelomycterus]

@jmgasper Keep you updated.
I'll test and push it tomorrow.

Discussions:

Comments.

[atelomycterus]

@jmgasper Ready for the review. Need to test the editor before using it in Prod. See found issues. Please apply PRs:
topcoder-platform/forums-groups-plugin#31
#238
topcoder-platform/forums-plugins#50

Attachments

Deleting attachments

User deletes files from a post/comment. Files are not deleted from cdn filestack. If we need to delete files from Filestack let me know. Deleting files from Filestack requires using Filestack API.

Know Issues

• downloaded files without extensions - [$40] Attachments are downloaded as unrecognized files  #104, txt file attachments cannot be downloaded or opened #155

Issues found during testing attachments

I've tried to use Markdown.

• insert images - quotes added incorrectly
• couldn't upload the same file as attachment and an image
• adding Url: cancel button is not working
• big spaces, formatting should be better
• smiles doesn't work in email template
• smiles is displayed in the center, formatting smiles is invalid

• wrong formatting with quotes/spoilers
  

I think you can find more issues if use draft/preview and check permissions and so on.

Recommendation for testing

• max size: please upload one file/multiple files. Need configre dev/prod with max size.
• permissions: This editor use the own permssion + modifies default Vanilla settings and set 'upload files = 1' for any categories.
• delete files and upload files again
• test 'review' without/with attachments
• test 'draft' without/with attachments
• toggle full page
• use Markdown and check styles