Skip to content

Issues-521: Added caching Challenge data(ChallengeID,IsNDA), Issues-524 #94

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 19, 2021
Merged

Issues-521: Added caching Challenge data(ChallengeID,IsNDA), Issues-524 #94

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
566b8c9
Issues-521: Added caching Challenge data(ChallengeID,IsNDA)
atelomycterus Apr 19, 2021
9535688
Issues-521: Added caching Challenge data(ChallengeID,IsNDA)
atelomycterus Apr 19, 2021
b25da62
Issues-524: Added PreferencesKey in sortsDropDown
atelomycterus Apr 19, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
128 changes: 122 additions & 6 deletions Topcoder/class.topcoder.plugin.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ class TopcoderPlugin extends Gdn_Plugin {
const CACHE_KEY_TOPCODER_PROFILE = 'topcoder.{UserID}';
const CACHE_TOPCODER_KEY_TOPCODER_PROFILE = 'topcoder.{Handle}';
const CACHE_TOPCODER_KEY_TOPCODER_ROLE_RESOURCES = 'topcoder.roleresources';
const CACHE_TOPCODER_KEY_TOPCODER_CHALLENGE = 'topcoder.challenge.{ChallengeID}';
const CACHE_TOPCODER_KEY_TOPCODER_CHALLENGE_RESOURCES = 'topcoder.challenge.{ChallengeID}.resources';

const CACHE_DEFAULT_EXPIRY_TIME = 60*60*3; //The default expiration time in Memcached is in seconds, 10800 = 3 hours
Expand Down Expand Up @@ -1446,11 +1447,11 @@ public function getChallengeResources($challengeId) {
}

$expirationTime = self::CACHE_DEFAULT_EXPIRY_TIME;
$challenge = self::loadChallenge($challengeId);
if($challenge && count($challenge) > 0) {
$challenge = self::getChallenge($challengeId);
if($challenge) {
// Set expiration time for Challenge roles
$endDate = strtotime($challenge[0]->endDate);
$startDate = strtotime($challenge[0]->startDate);
$endDate = $challenge['EndDate'];
$startDate =$challenge['StartDate'];
// $duration = $endDate > -1 && $startDate > -1 ? $endDate - $startDate: 0;
// archived
$isEnded = $endDate > -1 && now() - $endDate > 0;
Expand Down Expand Up @@ -1520,6 +1521,43 @@ private static function loadChallengeResources($challengeId) {
return null;
}

/**
* Get Topcoder Challenge by ChallengeId
* @param $challengeId
* @return mixed|null
*/
public function getChallenge($challengeId) {
$challenge = self::getChallengeFromCache($challengeId);
if ($challenge) {
return $challenge;
}

$cachedChallenge = ['ChallengeID' => $challengeId];
$challenge = self::loadChallenge($challengeId);

$expirationTime = self::CACHE_DEFAULT_EXPIRY_TIME;
if($challenge) {
// Set expiration time for Challenge roles
$startDate = strtotime($challenge->startDate);
$endDate = strtotime($challenge->endDate);
// archived
$isEnded = $endDate > -1 && now() - $endDate > 0;
if(!$isEnded) {
$expirationTime = self::CACHE_ONE_DAY_EXPIRY_TIME;
}
$cachedChallenge['StartDate'] = $startDate;
$cachedChallenge['EndDate'] = $endDate;
$termIDs = array_column($challenge->terms, 'id');
$NDA_UUID = c('Plugins.Topcoder.NDA_UUID');
$cachedChallenge['IsNDA'] = in_array($NDA_UUID, $termIDs);
}
if (Gdn_Cache::activeEnabled()) {
self::topcoderChallengeCache($challengeId, $cachedChallenge, $expirationTime);
}
return $cachedChallenge;
}


/**
* Load Topcoder Challenge by Challenge ID
* @param $challengeId
Expand All @@ -1535,7 +1573,7 @@ private static function loadChallenge($challengeId) {
'header' => 'Authorization: Bearer ' .$token
));
$context = stream_context_create($options);
$data = file_get_contents($topcoderChallengeApiUrl . '?challengeId=' . $challengeId, false, $context);
$data = file_get_contents($topcoderChallengeApiUrl . $challengeId, false, $context);
if ($data === false) {
// Handle errors (e.g. 404 and others)
self::log('Couldn\'t get challenge: no token', ['headers'=> json_encode($http_response_header)]);
Expand All @@ -1549,6 +1587,35 @@ private static function loadChallenge($challengeId) {
return null;
}

/**
* Load challenge from cache
* @param $challengeID
* @return false|mixed
*/
private static function getChallengeFromCache($challengeID) {
if(!Gdn_Cache::activeEnabled()) {
return false;
}

$handleKey = formatString(self::CACHE_TOPCODER_KEY_TOPCODER_CHALLENGE, ['ChallengeID' => $challengeID]);
if(!Gdn::cache()->exists($handleKey)) {
return false;
}
$challenge = Gdn::cache()->get($handleKey);
if ($challenge === Gdn_Cache::CACHEOP_FAILURE) {
return false;
}
return $challenge;
}

private static function topcoderChallengeCache($challengeID, $challenge, $expirationTime = self::CACHE_DEFAULT_EXPIRY_TIME) {
$challengeKey = formatString(self::CACHE_TOPCODER_KEY_TOPCODER_CHALLENGE, ['ChallengeID' => $challengeID]);
return Gdn::cache()->store($challengeKey , $challenge, [
Gdn_Cache::FEATURE_EXPIRY => $expirationTime
]);
}


/**
* Get a Topcoder Roles
*
Expand Down Expand Up @@ -1761,13 +1828,15 @@ public static function getUserPhotoUrl($user) {
// Set Topcoder Project Roles Data for a challenge
private function setTopcoderProjectData($sender, $challengeID) {
if($challengeID) {
$challenge = $this->getChallenge($challengeID);
$resources = $this->getChallengeResources($challengeID);
$roleResources = $this->getRoleResources();
$currentProjectRoles = $this->getTopcoderProjectRoles(Gdn::session()->User, $resources, $roleResources);
if($currentProjectRoles) {
$currentProjectRoles = array_map('strtolower',$currentProjectRoles);
}

$sender->Data['Challenge'] = $challenge;
$sender->Data['ChallengeResources'] = $resources;
$sender->Data['ChallengeRoleResources'] = $roleResources;
$sender->Data['ChallengeCurrentUserProjectRoles'] = $currentProjectRoles;
Expand All @@ -1777,7 +1846,7 @@ private function setTopcoderProjectData($sender, $challengeID) {
// }
self::log('setTopcoderProjectData', ['ChallengeID' => $challengeID, 'currentUser' => $currentProjectRoles,
'Topcoder Resources' => $resources , 'Topcoder RoleResources'
=> $roleResources,]);
=> $roleResources, 'challenge' =>$challenge]);
}
}

Expand Down Expand Up @@ -2483,3 +2552,50 @@ function topcoderMentionAnchor($mention, $cssClass = null, $options = null) {
}
}

if (!function_exists('watchingSorts')) {
/**
* Returns watching sorting.
*
* @param string $extraClasses any extra classes you add to the drop down
* @return string
*/
function watchingSorts($extraClasses = '') {
if (!Gdn::session()->isValid()) {
return;
}

$baseUrl = preg_replace('/\?.*/', '', Gdn::request()->getFullPath());
$transientKey = Gdn::session()->transientKey();
$filters = [
[
'name' => t('New'),
'param' => 'sort',
'value' => 'new',
'extra' => ['TransientKey' => $transientKey, 'save' => 1]
],

[
'name' => t('Old'),
'param' => 'sort',
'value' => 'old',
'extra' => ['TransientKey' => $transientKey, 'save' => 1]
]
];

$defaultParams = [];
if (!empty($defaultParams)) {
$defaultUrl = $baseUrl.'?'.http_build_query($defaultParams);
} else {
$defaultUrl = $baseUrl;
}

return sortsDropDown('WatchingSort',
$baseUrl,
$filters,
$extraClasses,
null,
$defaultUrl,
'Sort'
);
}
}
6 changes: 3 additions & 3 deletions Topcoder/controllers/class.watchingcontroller.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,10 +56,10 @@ public function index($cp = '', $dp = '') {
$sort = Gdn::request()->get('sort', null);
$saveSorting = $sort !== null && Gdn::request()->get('save') && Gdn::session()->validateTransientKey(Gdn::request()->get('TransientKey', ''));
if($saveSorting) {
Gdn::session()->setPreference('CategorySort', $sort);
Gdn::session()->setPreference('WatchingSort', $sort);
}
$sort = Gdn::session()->getPreference('CategorySort', false);
$this->setData('CategorySort', $sort);
$sort = Gdn::session()->getPreference('WatchingSort', false);
$this->setData('WatchingSort', $sort);

$userMetaModel = new UserMetaModel();
list($cp, $categoryLimit) = offsetLimit($cp, 30);
Expand Down