Skip to content

Issues-476:Show Copilot/Reviewer roles and hide other challenge roles #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 24, 2021
Merged

Issues-476:Show Copilot/Reviewer roles and hide other challenge roles #68

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions class.groups.plugin.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -746,10 +746,15 @@ private function getMediaData($type, $id) {
public function base_userAnchor_handler($sender, $args){
if($sender instanceof DiscussionController || $sender instanceof GroupController) {
$user = $args['User'];
$isTopcoderAdmin = $args['IsTopcoderAdmin'];
$anchorText = &$args['Text'];
$resources = $sender->data('ChallengeResources');
$roleResources = $sender->data('ChallengeRoleResources');
$anchorText = $anchorText . $this->topcoderProjectRolesText($user, $resources, $roleResources);
$anchorText = '<span class="topcoderHandle">'.$anchorText.'</span>';
// Don't show Topcoder Challenge roles for admin roles
if(!$isTopcoderAdmin){
$anchorText = $anchorText . $this->topcoderProjectRolesText($user, $resources, $roleResources);
}
}
}

Expand All @@ -764,14 +769,14 @@ public function base_userPhoto_handler($sender, $args){
$anchorText = &$args['Title'];
$resources = $sender->data('ChallengeResources');
$roleResources = $sender->data('ChallengeRoleResources');
$anchorText = $anchorText . $this->topcoderProjectRolesText($user, $resources, $roleResources);
}
}

private function topcoderProjectRolesText($user, $resources = null, $roleResources = null) {
$roles = $this->getTopcoderProjectRoles($user, $resources, $roleResources);
return count($roles) > 0 ? '(' . implode(', ', $roles) . ')' : '';

// FIX: https://github.com/topcoder-platform/forums/issues/476: Show only Copilot, Reviewer roles
$displayedRoles = array_intersect(array_unique($roles), ["Copilot", "Reviewer"]);
return count($displayedRoles) > 0 ? ' <span class="challengeRoles">(' . implode(', ', $displayedRoles) . ')</span>' : '';
}

/**
Expand Down