Skip to content

fix: duplicate payment generation #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 24, 2024
Merged

fix: duplicate payment generation #74

merged 1 commit into from
Apr 24, 2024

Conversation

rakibansary
Copy link
Contributor

  • on re-opening a completed challenge and closing it again
  • the updateForACL method is re-triggered leading to re-creation
  • of already created payments. This pull request prevents the
  • re-generation of payments by checking if payments have already
  • been created for a given challenge id

* on re-opening a completed challenge and closing it again
* the updateForACL method is re-triggered leading to re-creation
* of already created payments. This pull request prevents the
* re-generation of payments by checking if payments have already
* been created for a given challenge id

Signed-off-by: Rakib Ansary <[email protected]>
rakibansary added a commit that referenced this pull request Apr 24, 2024
* see #74

Signed-off-by: Rakib Ansary <[email protected]>
Copy link
Collaborator

@jmgasper jmgasper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok

@rakibansary rakibansary merged commit 9e875e1 into main Apr 24, 2024
1 check passed
@rakibansary rakibansary deleted the PS-256 branch April 24, 2024 14:50
rakibansary added a commit that referenced this pull request Apr 25, 2024
* see #74

Signed-off-by: Rakib Ansary <[email protected]>
rakibansary added a commit that referenced this pull request Apr 25, 2024
* see #74

Signed-off-by: Rakib Ansary <[email protected]>
rakibansary added a commit that referenced this pull request Apr 25, 2024
* see #74

Signed-off-by: Rakib Ansary <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants