communities on dashboard, listing refactor, groups filters #89
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, backend allows to load at most 50 challenge objects by a single request. In prod we have typically around 30-50 active challenge at the same time, thus most of the time this change won't have any impact on the performance. Even if, eventually, there will be more than 50 active challenges, a few additional requests are not a big deal for the peformance. On the other hand, assuming that all active challenges are already loaded into the frontend allows to simplify a lot of code at the frontend side, and to provide a better and more consistent user experience when filtering&counting challenges in the challenge listing.
There just a few callbacks that demands to create some additional actions, which will be handled a bit later.
A safe point before removing the old filters implementation
A new portion of changes
The only submission to the challenge by ouyangki: https://software.topcoder.com/review/actions/ViewProjectDetails?pid=30058042 There are some minor problems, but in general it looks fine, thus adding to the repo before the end of reviews / appeals.
__tests__/shared/components/examples/__snapshots__/Content.jsx.snap
There are some problems, mostly inherited from the previous version of the code. Especially, reordering of user-saved filters in the edit mode, and subsequent saving of the order, these just do not work (though, this functionality neither works in current prod).
Also includes community selector into all challenge listings (including outside the a community mini-site).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.