Skip to content

PM-210: Fix privacy violations #7034

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Jan 17, 2025
Merged

PM-210: Fix privacy violations #7034

merged 11 commits into from
Jan 17, 2025

Conversation

hentrymartin
Copy link
Collaborator

What's in this PR?

  • Added checks to check safe tags when rendering contentful pages
  • Instead of spreading whole props object in the reported files, changed to only pass the props that are needed inside the child component

@hentrymartin hentrymartin marked this pull request as ready for review January 17, 2025 16:28
kkartunov
kkartunov approved these changes Jan 17, 2025
View reviewed changes
Copy link
Collaborator

@kkartunov kkartunov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@hentrymartin hentrymartin merged commit ada2da3 into develop Jan 17, 2025
4 checks passed
@hentrymartin hentrymartin deleted the pm-210 branch January 17, 2025 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kkartunov kkartunov kkartunov approved these changes

@ajefts ajefts Awaiting requested review from ajefts ajefts is a code owner

@luizrrodrigues luizrrodrigues Awaiting requested review from luizrrodrigues luizrrodrigues is a code owner

@jmgasper jmgasper Awaiting requested review from jmgasper

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hentrymartin @kkartunov