Skip to content

PM-195 Removed settings, newsletter subscription forms, mailchimp service, newsletter archive contentful module #7032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Jan 17, 2025
Merged

PM-195 Removed settings, newsletter subscription forms, mailchimp service, newsletter archive contentful module #7032

merged 10 commits into from
Jan 17, 2025

Conversation

hentrymartin
Copy link
Collaborator

What's in this PR?

  • Removed settings route and its corresponding files from the code, as account settings is now rendered from platform ui
  • Removed newsletter subscription form component and its usage.

@hentrymartin hentrymartin marked this pull request as ready for review January 13, 2025 17:07
@hentrymartin hentrymartin changed the title PM-195 Removed settings, newsletter subscription forms PM-195 Removed settings, newsletter subscription forms, mailchimp service, newsletter archive contentful module Jan 13, 2025
jmgasper
jmgasper approved these changes Jan 13, 2025
View reviewed changes
Copy link
Collaborator

@jmgasper jmgasper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a lot here, but I don't see anything to note. Looks good!

kkartunov
kkartunov approved these changes Jan 15, 2025
View reviewed changes
Copy link
Collaborator

@kkartunov kkartunov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean up very well done.

@hentrymartin hentrymartin merged commit d9d3d74 into develop Jan 17, 2025
3 of 4 checks passed
@hentrymartin hentrymartin deleted the pm-195_1 branch January 17, 2025 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmgasper jmgasper jmgasper approved these changes

@kkartunov kkartunov kkartunov approved these changes

@ajefts ajefts Awaiting requested review from ajefts ajefts is a code owner

@luizrrodrigues luizrrodrigues Awaiting requested review from luizrrodrigues luizrrodrigues is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hentrymartin @jmgasper @kkartunov