Skip to content

fix(PM-204): open redirect issues #7027

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jan 13, 2025
Merged

fix(PM-204): open redirect issues #7027

merged 6 commits into from
Jan 13, 2025

Conversation

hentrymartin
Copy link
Collaborator

What's in this PR?

  • Fixed open redirect issues
  • Explicitly checking for base urls whether they are valid
  • Using URL constructor to construct the url

@hentrymartin hentrymartin marked this pull request as ready for review January 6, 2025 09:37
Copy link
Collaborator

@jmgasper jmgasper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple minor tweaks requested, thanks!

@hentrymartin
Copy link
Collaborator Author

@jmgasper Can you please approve this PR, if there are no more comments to be resolved?

@hentrymartin hentrymartin merged commit 3a6e94f into develop Jan 13, 2025
4 checks passed
@hentrymartin hentrymartin deleted the pm-204 branch January 13, 2025 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants