Skip to content

fix: fix challenge link for marathon match in member statics page #6303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 27, 2022

Conversation

morehappiness
Copy link
Collaborator

@morehappiness morehappiness commented Apr 20, 2022

fix: fix challenge link for marathon match in member statics page

Issue: https://topcoder.atlassian.net/browse/PROD-1599

@luizrrodrigues
Copy link
Collaborator

@morehappiness Can you share the issue to this one please?

@luizrrodrigues
Copy link
Collaborator

@jpeg22 Can you share the issue to this PR please?

@morehappiness
Copy link
Collaborator Author

https://www.topcoder.com/challenges/74f767e7-1fd8-452c-b699-a55175c599bc

f you go to a member profile who has a marathon match rating, and view the rating graph (over time), you can click on any point to see the info about that particular match.

The screen that is shown when you click is a legacy screen and needs to point to the current challenge page.

Example: On this chart: https://www.topcoder.com/members/wleite/details/?track=DATA_SCIENCE&subTrack=MARATHON_MATCH Mouse over one of the data points near the far right end of the graph, such as “Marathon Match 133”, then click the pop-up dialog. Instead of going to the old challenge details page, this should redirect you here: https://www.topcoder.com/challenges/5fb2b54f-055e-4059-8687-ebaa8dbd8a18

@@ -58,6 +59,23 @@ export default class HistoryGraph extends React.Component {
return 300;
}

onHandleDataPointClicked() {
const { challengeId, href } = this.state;
fetch(`${config.API.V5}/challenges?legacyId=${challengeId}`)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not need call this API to get UUID from challenge, if access challenge with legacyId CA will redirect to UUID url:
example:

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm, never notice that. will change that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants