Skip to content

Fix for Issue #4294 Dropdown hidden behind on profile settings page #4892

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Sep 16, 2020
Merged

Fix for Issue #4294 Dropdown hidden behind on profile settings page #4892

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
2f734e3
#4294: Fix dropdown issue being hidden behind footer on profile setti…
gets0ul Sep 10, 2020
e0ff94e
Merge remote-tracking branch 'remotes/upstream/milestone-20200924' in…
gets0ul Sep 14, 2020
f719dcd
Move out inline style to .scss file
gets0ul Sep 14, 2020
d307664
New scss for header
gets0ul Sep 14, 2020
980bbc4
Fix test snapshot.
gets0ul Sep 14, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion __tests__/shared/components/Header/__snapshots__/index.jsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,13 @@
// Jest Snapshot v1, https://goo.gl/fbAQLP

exports[`Default render 1`] = `
<div>
<div
style={
Object {
"zIndex": 2,
}
}
>
<TopNav
loggedIn={true}
logo={
Expand Down
2 changes: 1 addition & 1 deletion src/shared/components/Header/index.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ const Header = ({

if (TopNavRef) {
return (
<div>
<div style={{ zIndex: 2 }}>
<TopNavRef
menu={headerMenu || config.HEADER_MENU}
rightMenu={(
Expand Down
1 change: 1 addition & 0 deletions src/shared/components/TopcoderFooter/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,7 @@
font-weight: 400;
line-height: 21px;
position: relative;
z-index: 0;

@include xs-to-sm {
padding: 30px 30px 21px 30px;
Expand Down
2 changes: 1 addition & 1 deletion src/shared/routes/Topcoder/styles.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,6 @@
display: flex;
flex: 1 0 auto;
position: relative;
z-index: 0;
z-index: 1;
}
}