Skip to content

fix(profile-page): wrong MM url at history graph #4862

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

cagdas001
Copy link
Collaborator

Fix wrong MM URLs at ProfilePage/Stats/HistoryGraph

  • Old (wrong) URL: /challenges/<challengeId>
  • New (correct) URL: ${config.URL.COMMUNITY}/tc?module=MatchDetails&rd=<challengeId>

Ref #4760

@luizrrodrigues luizrrodrigues requested review from luizrrodrigues and removed request for sushilshinde and ajefts September 5, 2020 01:07
@luizrrodrigues luizrrodrigues changed the base branch from milestone-v1.3 to milestone-20200910 September 5, 2020 01:09
@luizrrodrigues luizrrodrigues changed the base branch from milestone-20200910 to milestone-v1.3 September 5, 2020 01:09
@luizrrodrigues
Copy link
Collaborator

@cagdas001 Can you PR to milestone-20200910 please?

@cagdas001 cagdas001 changed the base branch from milestone-v1.3 to milestone-20200910 September 5, 2020 06:45
@cagdas001 cagdas001 changed the title fix(profile-page): wrong MM url at history graph WIP: fix(profile-page): wrong MM url at history graph Sep 5, 2020
@cagdas001 cagdas001 marked this pull request as draft September 5, 2020 06:56
@cagdas001 cagdas001 marked this pull request as ready for review September 5, 2020 07:29
@cagdas001 cagdas001 changed the title WIP: fix(profile-page): wrong MM url at history graph fix(profile-page): wrong MM url at history graph Sep 5, 2020
@cagdas001
Copy link
Collaborator Author

@luizrrodrigues ready

@luizrrodrigues luizrrodrigues merged commit b1368b2 into topcoder-platform:milestone-20200910 Sep 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants