Skip to content

Contentful updates #4703

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 25 commits into from
Aug 4, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
6c251ef
#4503
kkartunov Jun 10, 2020
5849311
Update config.yml
kkartunov Jun 10, 2020
6919d84
Implements #4542
kkartunov Jul 21, 2020
3c94152
Fix #4662
kkartunov Jul 21, 2020
3a0a234
Implement #4665
kkartunov Jul 21, 2020
53b89c0
#4662 fixed avatar urls
kkartunov Jul 22, 2020
63d15d1
Merge branch 'master' into feature-contentful
kkartunov Jul 22, 2020
cad5866
ci: feature-contentful on dev
kkartunov Jul 23, 2020
9b298b1
#4655 fix
kkartunov Jul 23, 2020
678f6e1
Default avatar for #4662
kkartunov Jul 24, 2020
1e48831
Merge branch 'master' into feature-contentful-tabs-urls
kkartunov Jul 24, 2020
d8687a7
ci: feature-contentful-tabs-urls on dev
kkartunov Jul 24, 2020
876f5b8
Merge branch 'feature-contentful-tabs-urls' of https://github.com/top…
kkartunov Jul 24, 2020
94c6cad
Updates #4679
kkartunov Jul 27, 2020
8c6ea7a
Share icons Thrive #4679
kkartunov Jul 30, 2020
58e2623
for #4697
kkartunov Jul 30, 2020
97d5a09
Fixes for #4697
kkartunov Jul 31, 2020
24365e6
Mobile image for image component
kkartunov Aug 2, 2020
744de10
Fonal tweeks #4697
kkartunov Aug 2, 2020
1b860ac
Merge branch 'contentful-mobile' into feature-contentful
kkartunov Aug 2, 2020
504d994
Mobile inline styles support
kkartunov Aug 2, 2020
86a2263
window is not defined fix
kkartunov Aug 3, 2020
b3511fd
Merge pull request #4701 from topcoder-platform/feature-contentful
sushilshinde Aug 3, 2020
807fd0c
Merge branch 'feature-contentful-tabs-urls'
kkartunov Aug 3, 2020
747e8f6
Merge pull request #4702 from topcoder-platform/feature-contentful
sushilshinde Aug 3, 2020
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -231,6 +231,7 @@ workflows:
branches:
only:
- develop
- feature-contentful
# This is alternate dev env for parallel testing
- "build-test":
context : org-global
Expand All @@ -252,6 +253,7 @@ workflows:
branches:
only:
- develop
- feature-contentful
# This is stage env for production QA releases
- "build-prod-staging":
context : org-global
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
exports[`Matches shallow shapshot 1`] = `
<div
id="image-1"
style={Object {}}
>
<InlineSVG
baseURL=""
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,9 @@
// Jest Snapshot v1, https://goo.gl/fbAQLP

exports[`Matches shallow shapshot 1`] = `
<a>
<a
style={Object {}}
>
<div>
<div
style={
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,10 @@ exports[`Matches shallow shapshot 1`] = `
<div
className="undefined "
>
<a
href="/thrive"
<Link
to="/thrive"
>
THRIVE
</a>
</Link>
</div>
`;
Original file line number Diff line number Diff line change
Expand Up @@ -44,16 +44,10 @@ exports[`Matches shallow shapshot 1`] = `
<span
className="src-shared-components-Leaderboard-LeaderboardTable-themes-___styles__leaderboard-avatar___21pJ3"
>
<ThemedAvatar
composeAdhocTheme="deeply"
composeContextTheme="softly"
mapThemrProps={[Function]}
theme={
Object {
"avatar": "src-shared-components-Leaderboard-avatarStyles___default___1bHTzy",
}
}
themePriority="adhoc-context-default"
<DefaultAvatar
data-name="Layer 1"
viewBox="0 0 33 33.00137"
xmlns="http://www.w3.org/2000/svg"
/>
</span>
</td>
Expand Down Expand Up @@ -97,16 +91,10 @@ exports[`Matches shallow shapshot 1`] = `
<span
className="src-shared-components-Leaderboard-LeaderboardTable-themes-___styles__leaderboard-avatar___21pJ3"
>
<ThemedAvatar
composeAdhocTheme="deeply"
composeContextTheme="softly"
mapThemrProps={[Function]}
theme={
Object {
"avatar": "src-shared-components-Leaderboard-avatarStyles___default___1bHTzy",
}
}
themePriority="adhoc-context-default"
<DefaultAvatar
data-name="Layer 1"
viewBox="0 0 33 33.00137"
xmlns="http://www.w3.org/2000/svg"
/>
</span>
</td>
Expand Down Expand Up @@ -150,16 +138,10 @@ exports[`Matches shallow shapshot 1`] = `
<span
className="src-shared-components-Leaderboard-LeaderboardTable-themes-___styles__leaderboard-avatar___21pJ3"
>
<ThemedAvatar
composeAdhocTheme="deeply"
composeContextTheme="softly"
mapThemrProps={[Function]}
theme={
Object {
"avatar": "src-shared-components-Leaderboard-avatarStyles___default___1bHTzy",
}
}
themePriority="adhoc-context-default"
<DefaultAvatar
data-name="Layer 1"
viewBox="0 0 33 33.00137"
xmlns="http://www.w3.org/2000/svg"
/>
</span>
</td>
Expand Down Expand Up @@ -203,16 +185,10 @@ exports[`Matches shallow shapshot 1`] = `
<span
className="src-shared-components-Leaderboard-LeaderboardTable-themes-___styles__leaderboard-avatar___21pJ3"
>
<ThemedAvatar
composeAdhocTheme="deeply"
composeContextTheme="softly"
mapThemrProps={[Function]}
theme={
Object {
"avatar": "src-shared-components-Leaderboard-avatarStyles___default___1bHTzy",
}
}
themePriority="adhoc-context-default"
<DefaultAvatar
data-name="Layer 1"
viewBox="0 0 33 33.00137"
xmlns="http://www.w3.org/2000/svg"
/>
</span>
</td>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,16 +7,10 @@ exports[`Matches shallow shapshot 1`] = `
<span
className="src-shared-components-Leaderboard-PodiumSpot-themes-___styles__leaderboard-avatar___JjdZ_"
>
<ThemedAvatar
composeAdhocTheme="deeply"
composeContextTheme="softly"
mapThemrProps={[Function]}
theme={
Object {
"avatar": "src-shared-components-Leaderboard-avatarStyles___gold___1KUGNq",
}
}
themePriority="adhoc-context-default"
<DefaultAvatar
data-name="Layer 1"
viewBox="0 0 33 33.00137"
xmlns="http://www.w3.org/2000/svg"
/>
<div
className="src-shared-components-Leaderboard-PodiumSpot-themes-___styles__ranking___3eGBy"
Expand Down Expand Up @@ -72,16 +66,10 @@ exports[`Matches shallow shapshot 2`] = `
<span
className="src-shared-components-Leaderboard-PodiumSpot-themes-___styles__leaderboard-avatar___JjdZ_"
>
<ThemedAvatar
composeAdhocTheme="deeply"
composeContextTheme="softly"
mapThemrProps={[Function]}
theme={
Object {
"avatar": "src-shared-components-Leaderboard-avatarStyles___gold___1KUGNq",
}
}
themePriority="adhoc-context-default"
<DefaultAvatar
data-name="Layer 1"
viewBox="0 0 33 33.00137"
xmlns="http://www.w3.org/2000/svg"
/>
<div
className="src-shared-components-Leaderboard-PodiumSpot-themes-___styles__ranking___3eGBy"
Expand Down
1 change: 1 addition & 0 deletions src/assets/images/default-avatar-photo.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
11 changes: 11 additions & 0 deletions src/assets/images/icon-facebook.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
11 changes: 11 additions & 0 deletions src/assets/images/icon-linkedIn.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
11 changes: 11 additions & 0 deletions src/assets/images/icon-twitter.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
23 changes: 23 additions & 0 deletions src/assets/images/minimal-down.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
6 changes: 5 additions & 1 deletion src/shared/actions/leaderboard.js
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,11 @@ async function getTcoHistoryChallengesDone(url, competitor) {
const res = await fetch(url)
.then(response => response.json())
.then(jsonResponse => ({
challenges: _.filter(jsonResponse, challenge => challenge.userid === competitor.userid),
challenges: _.filter(jsonResponse, challenge => (
challenge['tco_leaderboard.user_id']
? (challenge['tco_leaderboard.user_id'] === competitor['tco_leaderboard.user_id'])
: (challenge.userid === competitor.userid)
)),
}));
return res;
}
Expand Down
64 changes: 42 additions & 22 deletions src/shared/components/Contentful/Article/Article.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -15,13 +15,14 @@ import LoadingIndicator from 'components/LoadingIndicator';
import YouTubeVideo from 'components/YouTubeVideo';
import moment from 'moment';
import localStorage from 'localStorage';
import { config } from 'topcoder-react-utils';
import ShareSocial from 'components/challenge-detail/Specification/SideBar/ShareSocial';
import { config, Link, isomorphy } from 'topcoder-react-utils';
import qs from 'qs';
// SVGs and assets
import GestureIcon from 'assets/images/icon-gesture.svg';
import UserDefault from 'assets/images/ico-user-default.svg';
import ReadMoreArrow from 'assets/images/read-more-arrow.svg';
import qs from 'qs';
import IconFacebook from 'assets/images/icon-facebook.svg';
import IconTwitter from 'assets/images/icon-twitter.svg';
import IconLinkedIn from 'assets/images/icon-linkedIn.svg';

const htmlToText = require('html-to-text');

Expand Down Expand Up @@ -105,20 +106,31 @@ export default class Article extends React.Component {
spaceName, environment, preview,
};
const { upvotes, downvotes } = this.state || {};
let shareUrl;
if (isomorphy.isClientSide()) {
shareUrl = encodeURIComponent(window.location.href);
}

return (
<React.Fragment>
{/* Banner */}
<div className={theme.bannerContainer}>
{
fields.featuredImage ? (
<div className={theme.featuredImage} style={{ backgroundImage: `url(${subData.assets.items[fields.featuredImage.sys.id].fields.file.url})` }} />
) : null
}
</div>
<div className={theme.bannerBottomShape} />
{
fields.featuredImage ? (
<div className={theme.bannerContainer}>
<svg viewBox="0 25 1050 600" version="1.1" preserveAspectRatio="none" className={theme['site-header-background']}>
<defs>
<clipPath id="user-space" clipPathUnits="userSpaceOnUse">
<path id="jagged-top" d="M955.643,455.426c113.929-152.899,130.923-281.812-19.966-387.73 C883.769,31.258,814.91-10.997,685,3c-87.558,9.434-218,32-332,9c-48.207-9.726-146.137-5.765-167.796,6.768 C45.296,99.719-82.626,352.551,69.262,473.459c151.887,120.908,379.734,0.979,533.623,75.92 C756.773,624.319,841.715,608.326,955.643,455.426" />
</clipPath>
</defs>
<image width="100%" height="100%" preserveAspectRatio="none" href={subData.assets.items[fields.featuredImage.sys.id].fields.file.url} clipPath="url(#user-space)" />
</svg>
</div>
) : null
}
<div
className={theme.contentContainer}
className={fields.featuredImage
? theme.contentContainerWithBanner : theme.contentContainer}
style={fixStyle(fields.extraStylesForContainer)}
>
<div className={theme.contentLeftBar}>
Expand All @@ -139,9 +151,7 @@ export default class Article extends React.Component {
)}
renderPlaceholder={LoadingIndicator}
/>
) : (
<UserDefault alt="article author avatar" className={theme.avatar} />
)
) : null
}
<div className={theme.authorInfos}>
<span className={theme.name}>
Expand Down Expand Up @@ -169,14 +179,24 @@ export default class Article extends React.Component {
{
_.map(fields.tags, tag => (
<div className={theme.tagItem} key={tag} title={`Search for articles labelled as ${tag}`}>
<a href={`${config.TC_EDU_BASE_PATH}${config.TC_EDU_SEARCH_PATH}?${qs.stringify({ tags: tag })}`} key={`${tag}`}>{tag}</a>
<Link to={`${config.TC_EDU_BASE_PATH}${config.TC_EDU_SEARCH_PATH}?${qs.stringify({ tags: tag })}`} key={`${tag}`}>{tag}</Link>
</div>
))
}
</div>
<div className={theme.separator} />
<h3 className={theme.label}>share</h3>
<ShareSocial />
<div className={theme.shareButtons}>
<a href={`https://www.linkedin.com/sharing/share-offsite/?url=${shareUrl}`} target="_blank" rel="noopener noreferrer">
<IconLinkedIn />
</a>
<a href={`https://www.facebook.com/sharer/sharer.php?u=${shareUrl}&src=share_button`} target="_blank" rel="noopener noreferrer">
<IconFacebook />
</a>
<a href={`https://twitter.com/intent/tweet?url=${shareUrl}`} target="_blank" rel="noopener noreferrer">
<IconTwitter />
</a>
</div>
<div className={theme.mobileSeparator} />
</div>
{/* Content */}
Expand Down Expand Up @@ -250,9 +270,9 @@ export default class Article extends React.Component {
{subData.entries.items[rec.sys.id].fields.title}
</a>
) : (
<a href={`${config.TC_EDU_BASE_PATH}${config.TC_EDU_ARTICLES_PATH}/${subData.entries.items[rec.sys.id].fields.slug || subData.entries.items[rec.sys.id].fields.title}`}>
<Link to={`${config.TC_EDU_BASE_PATH}${config.TC_EDU_ARTICLES_PATH}/${subData.entries.items[rec.sys.id].fields.slug || subData.entries.items[rec.sys.id].fields.title}`}>
{subData.entries.items[rec.sys.id].fields.title}
</a>
</Link>
)
}
</h3>
Expand All @@ -278,9 +298,9 @@ export default class Article extends React.Component {
Read More <ReadMoreArrow />
</a>
) : (
<a href={`${config.TC_EDU_BASE_PATH}${config.TC_EDU_ARTICLES_PATH}/${subData.entries.items[rec.sys.id].fields.slug || subData.entries.items[rec.sys.id].fields.title}`} className={theme.readMore}>
<Link to={`${config.TC_EDU_BASE_PATH}${config.TC_EDU_ARTICLES_PATH}/${subData.entries.items[rec.sys.id].fields.slug || subData.entries.items[rec.sys.id].fields.title}`} className={theme.readMore}>
Read More <ReadMoreArrow />
</a>
</Link>
)
}
</div>
Expand Down
Loading