Skip to content

fix: change <time> to register to <time> to go #4476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 6, 2020
Merged

fix: change <time> to register to <time> to go #4476

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion __tests__/shared/components/challenge-listing/ChallengeCard/__snapshots__/Status.jsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@ exports[`Matches shallow shapshot shapshot 1 1`] = `
<span
className="src-shared-components-challenge-listing-ChallengeCard-Status-___style__to-register___17rpT"
>
to register
to go
</span>
</a>
</div>
Expand Down
2 changes: 1 addition & 1 deletion src/shared/components/challenge-detail/RecommendedActiveChallenges/ChallengesCard/index.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ export default function ChallengesCard({
</div>

<div styleName="bottom">
<span>{getTimeLeft(statusPhase, 'to register').text}</span>
<span>{getTimeLeft(statusPhase, 'to go').text}</span>
</div>
</div>
);
Expand Down
6 changes: 3 additions & 3 deletions src/shared/components/challenge-listing/ChallengeCard/Status/index.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,7 @@ export default function ChallengeStatus(props) {
challenge,
detailLink,
} = props;
const timeDiff = getTimeLeft((challenge.allPhases || challenge.phases || []).find(p => p.name === 'Registration'), 'to register');
const timeDiff = getTimeLeft((challenge.allPhases || challenge.phases || []).find(p => p.name === 'Registration'), 'to go');
let timeNote = timeDiff.text;
/* TODO: This is goofy, makes the trick, but should be improved. The idea
* here is that the standard "getTimeLeft" method, for positive times,
Expand All @@ -150,7 +150,7 @@ export default function ChallengeStatus(props) {
{timeNote}
</span>
<span styleName="to-register">
to register
to go
</span>
</a>
);
Expand Down Expand Up @@ -278,7 +278,7 @@ export default function ChallengeStatus(props) {
isLate={moment().isAfter(statusPhase.scheduledEndDate)}
/>
<div styleName="time-left">
{getTimeLeft(statusPhase, 'to register').text}
{getTimeLeft(statusPhase, 'to go').text}
</div>
</div>
) : <ChallengeProgressBar color="gray" value="100" />
Expand Down