Skip to content

Changes phase.isActive to phase.isOpen #4446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 2, 2020
Merged

Changes phase.isActive to phase.isOpen #4446

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions src/shared/components/SubmissionPage/Submit/index.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,13 +80,13 @@ class Submit extends React.Component {
let subPhaseId;

// Submission type logic
if (checkpoint && checkpoint.isActive) {
if (checkpoint && checkpoint.isOpen) {
subType = 'Checkpoint Submission';
subPhaseId = checkpoint.id;
} else if (checkpoint && !checkpoint.isActive && submission && submission.isActive) {
} else if (checkpoint && !checkpoint.isOpen && submission && submission.isOpen) {
subType = 'Contest Submission';
subPhaseId = submission.id;
} else if (finalFix && finalFix.isActive) {
} else if (finalFix && finalFix.isOpen) {
subType = 'Studio Final Fix Submission';
subPhaseId = finalFix.id;
} else {
Expand Down
2 changes: 1 addition & 1 deletion src/shared/components/challenge-detail/Submissions/index.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -245,7 +245,7 @@ class SubmissionsComponent extends React.Component {

let isReviewPhaseComplete = false;
_.forEach(allPhases, (phase) => {
if (phase.name === 'Review' && !phase.isActive) {
if (phase.name === 'Review' && !phase.isOpen) {
isReviewPhaseComplete = true;
}
});
Expand Down
2 changes: 1 addition & 1 deletion src/shared/components/challenge-listing/ChallengeCard/index.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ function ChallengeCard({
}

const registrationPhase = (challenge.allPhases || challenge.phases || []).filter(phase => phase.name === 'Registration')[0];
const isRegistrationOpen = registrationPhase ? registrationPhase.isActive : false;
const isRegistrationOpen = registrationPhase ? registrationPhase.isOpen : false;

return (
<div ref={domRef} styleName="challengeCard">
Expand Down
2 changes: 1 addition & 1 deletion src/shared/components/challenge-listing/Tooltips/ProgressBarTooltip/index.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ function Tip(props) {
name: 'Checkpoint',
});
}
const iterativeReviewPhase = allPhases.find(phase => phase.isActive && phase.name === 'Iterative Review');
const iterativeReviewPhase = allPhases.find(phase => phase.isOpen && phase.name === 'Iterative Review');
if (iterativeReviewPhase) {
steps.push({
date: new Date(iterativeReviewPhase.scheduledEndDate),
Expand Down