Fix issue #187 #327
Fix issue #187 #327
Conversation
| if (filterState.tags) { | ||
| filterStateTags = Array.isArray(filterState.tags) ? filterState.tags.join(',') : | ||
| Object.keys(filterState.tags).map(key => filterState.tags[key]).join(','); | ||
| } |
There was a problem hiding this comment.
- For such checks we prefer to use lodash functions.
- Is really possible that we can get either array either object here? It looks strange.
| const filterSubtracks = state.subtracks.map(item => | ||
| const subtracks = Array.isArray(state.subtracks) ? state.subtracks : | ||
| Object.keys(state.subtracks).map(key => state.subtracks[key]); | ||
| const filterSubtracks = subtracks.map(item => |
There was a problem hiding this comment.
Especially here. It is just documented in the module's head comment that tags and subtracks must be arrays. So if it gets called with object, it is an error to be fixed somewhere else.
|
@birdofpreyru I found another way to solve this bug, please check again |
elfman
force-pushed
the
issue187
branch
2 times, most recently
from
89bded2 to
d733a6e
Compare
src/server/server.js
Outdated
| @@ -34,6 +35,8 @@ const app = express(); | |||
| * fix. */ | |||
| global.atob = atob; | |||
|
|
|||
| app.set('query parser', str => qs.parse(str, { arrayLimit: 1000 })); | |||
There was a problem hiding this comment.
@elfman It looks like you found the correct reason behind the issue, but I don't like this way solving it. The reason qs limits possible array lengths and turns array elements with indices larger than 20 into objects is the following: say you set limit 1000, then it is legit to send query param x[999]=... and the backend will have to create an array with 1000 elements for this param. I guess, it opens a very easy way to spam the server, if somebody wants to: you just send in a query like x[999]=a&y[999]=b&... and server will have lots of fun creating a big array for each of params.
So, I guess, we better just account in the reducer that long arrays are actually parsed as objects.
|
@birdofpreyru Updated |
elfman
force-pushed
the
issue187
branch
3 times, most recently
from
29452b8 to
ea65797
Compare
No description provided.