Skip to content

fix #3101 #3125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

fix #3101 #3125

wants to merge 1 commit into from

Conversation

zjuasmn
Copy link
Contributor

@zjuasmn zjuasmn commented Jul 26, 2019

upgrade topcoder-react-utils to 0.7.9, element should have a lang attribute

fix #3101

@veshu
Copy link
Contributor

veshu commented Jul 26, 2019

@zjuasmn Test is failing could you please check this?

@veshu veshu self-assigned this Jul 26, 2019
@zjuasmn
Copy link
Contributor Author

zjuasmn commented Jul 26, 2019

@veshu I am checking.

@veshu
Copy link
Contributor

veshu commented Jul 26, 2019

@zjuasmn Also I see this is related to contentful issue. Please add Contentful lable on PR as well. Thanks!

@veshu veshu removed their assignment Jul 26, 2019
@zjuasmn
Copy link
Contributor Author

zjuasmn commented Jul 26, 2019

@veshu I cannot fix this issue, topcoder-react-utils are responsible for server side rendering, the issue about lang attribute has been fixed in topcoder-platform/topcoder-react-utils@9e01fa2,
But versions in https://github.com/topcoder-platform/topcoder-react-utils is chaos.

Should I close this PR and mark the issue Open for pickup?

@zjuasmn zjuasmn closed this Jul 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants