Skip to content

MSFT 122 Issue#2820 - fixed improper heading level structure #3056

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 26, 2019
Merged

MSFT 122 Issue#2820 - fixed improper heading level structure #3056

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0134f6a
Merge pull request #1 from topcoder-platform/qa-accessibility
romitgit Jul 23, 2019
f276c9f
changed header level structure in challenge detail
romitrivigo Jul 25, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/shared/components/challenge-detail/Header/index.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -261,9 +261,9 @@ export default function ChallengeHeader(props) {
</div>
<div styleName="prizes-ops-container">
<div styleName="prizes-outer-container">
<h3 styleName="prizes-title">
<h2 styleName="prizes-title">
PRIZES
</h3>
</h2>
<Prizes prizes={prizes && prizes.length ? prizes : [0]} pointPrizes={pointPrizes} />
{
bonusType ? (
Expand Down
48 changes: 24 additions & 24 deletions src/shared/components/challenge-detail/Specification/SideBar/index.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,12 +100,12 @@ DOWNLOADS:
{
!isDesign && !isMM && (
<div>
<h3>
<h2>
REVIEW STYLE:
</h3>
<h4>
</h2>
<h3>
Final Review:
</h4>
</h3>
<span styleName="link-like-paragraph tooltip-container">
{reviewTypeTitle}
<Tooltip content={reviewTip}>
Expand All @@ -114,9 +114,9 @@ Final Review:
</div>
</Tooltip>
</span>
<h4>
<h3>
Approval:
</h4>
</h3>
<span styleName="link-like-paragraph tooltip-container">
User Sign-Off
<Tooltip content={approvalTip} className={styles['tooltip-overlay']}>
Expand All @@ -131,9 +131,9 @@ Approval:
{
!isMM && (
<div>
<h3>
<h2>
CHALLENGE LINKS:
</h3>
</h2>
{
isDevelop && environment && environment.length > 0
&& (
Expand Down Expand Up @@ -181,12 +181,12 @@ Approval:
isDesign
&& (
<div>
<h3>
<h2>
SUBMISSION FORMAT:
</h3>
<h4>
</h2>
<h3>
Your Design Files:
</h4>
</h3>
<ol>
<li>
{'Look for instructions in this challenge regarding what files to provide.'}
Expand Down Expand Up @@ -214,9 +214,9 @@ Your Design Files:
Read the FAQ.
</a>
</p>
<h4>
<h3>
Fonts, Stock Photos, and Icons:
</h4>
</h3>
<p styleName="link-like-paragraph">
All fonts, stock photos, and icons within your design must be declared
when you submit. DO NOT include any 3rd party files in your
Expand All @@ -227,9 +227,9 @@ Fonts, Stock Photos, and Icons:
here.
</a>
</p>
<h4>
<h3>
Screening:
</h4>
</h3>
<p styleName="link-like-paragraph">
All submissions are screened for eligibility before the challenge
holder picks winners. Don
Expand All @@ -250,9 +250,9 @@ t let your hard work go to waste.
</a>
}
</p>
<h3>
<h2>
SOURCE FILES:
</h3>
</h2>
<ul styleName="source-files-list">
{
fileTypes && fileTypes.length > 0
Expand All @@ -267,9 +267,9 @@ SOURCE FILES:
<p styleName="link-like-paragraph">
You must include all source files with your submission.
</p>
<h3>
<h2>
SUBMISSION LIMIT:
</h3>
</h2>
<p styleName="link-like-paragraph">
{
submissionLimit
Expand All @@ -287,9 +287,9 @@ SUBMISSION LIMIT:
terms.length > 0
&& (
<div>
<h3>
<h2>
CHALLENGE TERMS:
</h3>
</h2>
<div styleName="link-like-paragraph">
{
terms.map(t => (
Expand All @@ -308,9 +308,9 @@ CHALLENGE TERMS:
}
{ shareable && (
<div>
<h3>
<h2>
SHARE:
</h3>
</h2>
<ShareSocial />
</div>
)}
Expand Down
6 changes: 3 additions & 3 deletions src/shared/components/challenge-detail/Specification/SideBar/styles.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@
padding-bottom: 7px;
}

h3 {
h2 {
@include roboto-bold;

font-size: 13px;
Expand All @@ -100,7 +100,7 @@
padding-bottom: 2px;
}

h4 {
h3 {
@include roboto-bold;

font-size: 13px;
Expand All @@ -109,7 +109,7 @@
margin-top: 4 * $base-unit;
}

h4:first-of-type {
h3:first-of-type {
margin-top: 2 * $base-unit;
}

Expand Down