-
Notifications
You must be signed in to change notification settings - Fork 212
Fix issue #220 #301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issue #220 #301
Conversation
src/styles/_reset.scss
Outdated
@@ -169,3 +169,21 @@ a { | |||
color: inherit; | |||
} | |||
} | |||
|
|||
article > a { | |||
color: #3078df; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- The colors you use here do not really much design specs (https://drive.google.com/open?id=0B3y3SEA9cIEkRWt2TVpXMDhQbTA)!
- Also, you should not put color codes directly to your custom styling. We have all proper colors defined as variables here: https://github.com/topcoder-platform/community-app/blob/develop/src/styles/_variables.scss#L43
So, you just check what is the variable name for that color you need, and put you scsscolor: $tc-black;
or whatever you need.
@birdofpreyru changed "$tc-dark-blue: #0a71e6;" to "$tc-dark-blue: #0b71e6;" |
@twicoder I guess you have misunderstood me. You sure don't touch the values of variables in _variables.scss - they are the standard colors from Topcoder styleguide, being used all around, they should stay the same. What I ment, is that when you write a custom styling for hrefs rather than doing
you use those variables, like (provided that you have
Also I've just noticed that you attempted to put your custom styles into _reset.scss - this is also wrong. Inside |
@birdofpreyru Changed scss file as suggested. Value #0b71e6 is from design specs. |
@twicoder Btw, have you seen my last post in the challenge forum? I don't know what is your TC nickname to be able to pay for the Bug Hunt part of the challenge. |
@birdofpreyru My TC nickname is renqingwei123, I have post it in the forum. Thanks! |
|
Add some styles for