Topcoder open logo add title and aria-label. #3002
Conversation
|
@anonymousjaggu |
codeMinter
added
Accessibility
Code Review Failed
and removed
Code Review Passed
labels
|
@afrisalyp Please check the feedback here. |
|
According to some references, an inline SVG uses the <title> tag to describe the content. https://stackoverflow.com/questions/4697100/accessibility-recommended-alt-text-convention-for-svg-and-mathml Therefore we don't have to put alt in the TCO 2019 logo since it's not the proper way. Thanks. |
The issue is you have set aria-label="Topcoder open 2019" instead of "tco19" |
|
Yes. It's already done. Please check the file changes. |
| @@ -1,7 +1,7 @@ | |||
| <?xml version="1.0" encoding="UTF-8" standalone="no"?> | |||
| <svg width="109px" height="81px" viewBox="0 0 109 81" version="1.1" xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink"> | |||
| <svg width="109px" height="81px" viewBox="0 0 109 81" version="1.1" xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink" role="img" aria-label="Topcoder Open 2019"> | |||
There was a problem hiding this comment.
role="img" aria-label="Topcoder Open 2019"
@afrisalyp You are still using full form instead of "tco19" which is short form.
|
Oh, sorry. My mistake. I'll fix it. |
|
@afrisalyp please resolve the conflict |
…nity-app into issue-2830
|
@anonymousjaggu Done. |
#2830