Skip to content

Issue-2909 header menu up/down key. #2988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: qa-accessibility
Choose a base branch
from

Conversation

afrisalyp
Copy link
Collaborator

@veshu
Copy link
Contributor

veshu commented Jul 25, 2019

@sumitdaga @codeMinter please check this, old PR.

@codeMinter
Copy link
Contributor

@afrisalyp doesn't works for Tracks, I am able to use keydown for Compete and Community but not Tracks. This should work with all 3.

@afrisalyp
Copy link
Collaborator Author

@codeMinter This PR related with another PR for topcoder-react-utils.
topcoder-platform/topcoder-react-utils#42
Please review it. Thanks

@veshu
Copy link
Contributor

veshu commented Jul 28, 2019

@codeMinter Sorry if I miss anything related this, but do you have any suggestion what is blocking to review this?

@codeMinter
Copy link
Contributor

@veshu this needs local setup for topcoder-reat-utils, which I still need to setup so opened if another reviewer already has one setup

@veshu
Copy link
Contributor

veshu commented Jul 28, 2019

@sumitdaga @asadath1395 @luizrrodrigues Please check if you have local setup. Thanks!

@luizrrodrigues
Copy link
Collaborator

@veshu I'm trying setup the topcoder-react-utils but no luck yet.

Steps:
community-app

  • Checkout qa-accessibility
  • rimraf node_modules
  • npm i

topcoder-react-utils

  • Checkout qa-accessibility
  • npm i
  • npm run build:dev

community-app

  • npm link ../topcoder-react-utils
  • npm run build
  • Error in topcoder-react-utils missing package react-redux-toastr

topcoder-react-utils

  • npm i react-redux-toastr
  • npm run build:dev

community-app

  • npm link ../topcoder-react-utils
  • npm run build
  • Error in topcoder-react-utils missing package slick-carousel

topcoder-react-utils

  • npm i slick-carousel
  • npm run build:dev

community-app

  • npm link ../topcoder-react-utils
  • npm run build
  • Not showing a lot a missing packages:
    • draft-js
    • rc-tooltip
    • react-dates
    • topcoder-react-ui-kit
    • highlight.js

topcoder-react-utils

  • npm i draft-js rc-tooltip react-dates topcoder-react-ui-kit highlight.js
  • npm run build:dev

community-app

  • npm link ../topcoder-react-utils
  • npm run build
  • Now I get this error:

image

@veshu
Copy link
Contributor

veshu commented Jul 28, 2019

@sexta13 Is able to run it, I hope he will take this sooner. Thanks!

@sexta13 I am assigning you. Thanks

@veshu
Copy link
Contributor

veshu commented Jul 30, 2019

@sexta13 Will you able to review this? Thanks!

@sexta13
Copy link
Collaborator

sexta13 commented Jul 30, 2019

Right now i'm not able to run the react-utils....I'll try with v0.9 to see if it works...in 1hour more or less i'll give new feedback

@veshu
Copy link
Contributor

veshu commented Jul 31, 2019

@sexta13 Any progress here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants