Skip to content

Fix #2831 [MSFT-135] [Challenge Page] Eligible event section content is not read-out by the screen reader #2987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from
Closed

Fix #2831 [MSFT-135] [Challenge Page] Eligible event section content is not read-out by the screen reader #2987

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
cd9a2f6
Fix #2831 [MSFT-135] Eligible event section content is not read-out b…
asadath1395 Jul 22, 2019
257c0c8
Merge branch 'qa-accessibility' of https://github.com/asadath1395/com…
asadath1395 Jul 22, 2019
43494ae
Fix #2823 [MSFT-125] Sample challenge page: Screen reader reads the r…
asadath1395 Jul 22, 2019
081295d
Fix #2911 [MSFT-264] Keyboard access tab operational missing
asadath1395 Jul 22, 2019
89d1b1a
Fix #2806 [MSFT-102] Challenges page: Screen readers announce the det…
asadath1395 Jul 23, 2019
515f394
Fix #2824 [MSFT-126] Sample challenge page: There is a Question mark …
asadath1395 Jul 23, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/assets/images/tco19_logo_black.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 1 addition & 1 deletion src/client/styles.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,6 @@
* the page by Topcoder accounts-app. */
#tc-accounts-iframe {
border: none;
display: block;
display: none;
}
}
10 changes: 5 additions & 5 deletions src/shared/components/challenge-detail/Registrants/index.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,12 +99,12 @@ Round 1 Submitted Date

return (
<div styleName="row" key={r.handle}>
<div styleName="col-1">
<a href={`${config.URL.BASE}/members/${r.handle}`} style={colorStyle}>
<div styleName="col-1" tabIndex={0} role="button">
<a href={`${config.URL.BASE}/members/${r.handle}`} style={colorStyle} tabIndex={-1}>
{r.handle}
</a>
</div>
<div styleName="col-2">
<div styleName="col-2" tabIndex={0} role="button">
<div styleName="sm-only title">
Registration Date
</div>
Expand All @@ -113,7 +113,7 @@ Registration Date
{
twoRounds
&& (
<div styleName="col-3">
<div styleName="col-3" tabIndex={0} role="button">
<div styleName="sm-only title">
Round 1 Submitted Date
</div>
Expand All @@ -129,7 +129,7 @@ Round 1 Submitted Date
</div>
)
}
<div styleName="col-4">
<div styleName="col-4" tabIndex={0} role="button">
<div styleName="sm-only title">
{twoRounds ? 'Round 2 ' : ''}
Submitted Date
Expand Down
4 changes: 2 additions & 2 deletions src/shared/components/challenge-detail/Specification/SideBar/index.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ Final Review:
</h4>
<span styleName="link-like-paragraph tooltip-container">
{reviewTypeTitle}
<Tooltip content={reviewTip}>
<Tooltip content={reviewTip} trigger={['hover', 'focus']}>
<div styleName="tctooltip">
?
</div>
Expand All @@ -119,7 +119,7 @@ Approval:
</h4>
<span styleName="link-like-paragraph tooltip-container">
User Sign-Off
<Tooltip content={approvalTip} className={styles['tooltip-overlay']}>
<Tooltip content={approvalTip} className={styles['tooltip-overlay']} trigger={['hover', 'focus']}>
<div styleName="tctooltip">
?
</div>
Expand Down
8 changes: 4 additions & 4 deletions src/shared/components/challenge-listing/ChallengeCard/Prize/index.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,16 +19,16 @@ export default function Prize({
withoutTooltip,
}) {
const component = (
<div>
<div styleName="prize-wrapper">
<div styleName="label">
{label}
</div>
<div styleName="prize">
<span styleName="symbol">
{prizeUnitSymbol}
</span>
{totalPrize.toLocaleString()}
</div>
<div styleName="label">
{label}
</div>
</div>
);
if (withoutTooltip) return component;
Expand Down
6 changes: 6 additions & 0 deletions src/shared/components/challenge-listing/ChallengeCard/Prize/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,18 @@
@import "~styles/mixins";

.prize-wrapper {
display: flex;
flex-direction: column;
}

.label {
cursor: default;
padding: 0 (2 * $base-unit);
background: $tc-gray-neutral-light;
font-size: 10px;
color: $tc-gray-70;
white-space: nowrap;
order: 2;

@include xs-to-sm {
display: inline-block;
Expand Down