Skip to content

issue 2907 done #2953

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 21, 2019
Merged

issue 2907 done #2953

merged 4 commits into from
Jul 21, 2019

Conversation

rashmi73
Copy link
Contributor

@rashmi73 rashmi73 commented Jul 18, 2019 •
edited by codeMinter
Loading

issue #2907

@rashmi73 rashmi73 mentioned this pull request Jul 18, 2019
Closed
@codeMinter codeMinter self-assigned this Jul 19, 2019
@codeMinter
Copy link
Contributor

@rashmi73 can you please fix lint issues ? Also, request to mark ready for review when all tests pass on PR.

@codeMinter
Copy link
Contributor

codeMinter commented Jul 19, 2019 •
edited
Loading

@rashmi73 this is not the right way to fix this. You need to add color codes to https://github.com/topcoder-platform/topcoder-react-ui-kit or use one from there, if already available.

Once done, make sure you mark ticket as Ready for Review.

@codeMinter
Copy link
Contributor

@veshu I wasn't able to build topcoder-react-ui-kit locally, but going through the code, it looks fine to deploy for QA testing. Kindly note we will need to build first topcoder-archive/topcoder-platform-topcoder-react-ui-kit#11

@sushilshinde sushilshinde merged commit c1ea5cb into topcoder-platform:qa-accessibility Jul 21, 2019
@codeMinter codeMinter mentioned this pull request Jul 21, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajefts ajefts Awaiting requested review from ajefts ajefts is a code owner

@sushilshinde sushilshinde Awaiting requested review from sushilshinde sushilshinde is a code owner

Assignees

@codeMinter codeMinter

Labels
Accessibility Code Review Passed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rashmi73 @codeMinter @sushilshinde @veshu