Issue 2885 fix #2951
Merged
Issue 2885 fix #2951
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@veshu this looks good, kindly help move to QA for testing. |
|
@veshu Sorry for passing this, please hold. I will revert the merge. @PrakashDurlabhji please use or define a new one in https://github.com/topcoder-platform/topcoder-react-ui-kit and use the variable from there to be constant with how we manage this. |
|
@gurmeetb will it be ok if i change $tc-dark-blue-70 itself? this variable may be used at many places so even those color will change? will it be ok to change other places too and not just FORUM POSTS? |
codeMinter
added
Accessibility
Code Review Passed
and removed
Code Review Passed
labels
This was referenced Jan 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.