issue 2828 fix

[PrakashDurlabhji]

#2828 fix

[codeMinter]

@PrakashDurlabhji please fix all issues before marking ready for review.

[codeMinter]

@PrakashDurlabhji doesn't looks like we have tab enabled for Prizes. I have tried this on Windows and Mac both, there is no tab for Prizes. We need to enable tab for Prizes too.

[PrakashDurlabhji]

@codeMinter updating it

[codeMinter]

@PrakashDurlabhji Please flag where are we on this? I will wait for next 4 hrs for new PR with fix, after which will need to open this for others.

[PrakashDurlabhji]

@codeMinter just a minor change it should be update in few minutes

[PrakashDurlabhji]

@codeMinter @veshu PR updated

[veshu]

@PrakashDurlabhji Please check the tests are failing.

[codeMinter]

@PrakashDurlabhji any reason why you add role="button" ? It reads the prize and then reads button - prizes are not buttons

[PrakashDurlabhji]

@codeMinter i guess link will do.

[PrakashDurlabhji]

@codeMinter Pr updated

[codeMinter]

@codeMinter i guess link will do.

It is neither a link. I will research and suggest what should it be, but I guess since you are working on it, please can you look up Accessibility guidelines what you do for labels? It is just a label.

Going ahead, please do not mark for review unless everything is GREEN on PR, you might loose access to this repo else.

[PrakashDurlabhji]

@codeMinter sorry for it, I will make sure it wont happen again, but link shall do I feel

[veshu]

@PrakashDurlabhji Your fix is breaking on automated test, please ensure they are passing. Thanks!

[codeMinter]

@PrakashDurlabhji do not assign ticket to yourself, you cannot keep ticket forever.

[PrakashDurlabhji]

@codeMinter ya I understand I cannot keep ticket myself, but isnt this working as expected?

[codeMinter]

@PrakashDurlabhji plz do not open PRs for tickets not owned by you

[PrakashDurlabhji]

@codeMinter i want to check how can my PR failed while code is same, I wont link this PR to issue. I want to see how circleCI can behave weirdly

[PrakashDurlabhji]

@codeMinter let me see circleCI build job now. I will close PR again after that.

[codeMinter]

@PrakashDurlabhji run it locally. You cannot open PR and push commits, you are putting unnecessary load on our servers.

[PrakashDurlabhji]

@veshu waiting for your take on above issue. where a person delibaterly takes someone else issue which is made open, while he could have taken other issues which are open, though previous feedbacks are already pending for his current going issue, and PR is copied too.
Did not experience such biased decisions by reviewers
issue which was already in pending feedback by rohit, comments can be checked there too:
#2814

@codeMinter @r0hit-gupta

[crazyk07]

Hi @PrakashDurlabhji, there seems to be a misunderstanding here and Rohit has wrote an explanation in the ticket you are discussing. Our reviewers are just following procedure with code reviewing, I currently do not detect any bias. There could have been something procedural that was overlooked (Since we are dealing with 170 tickets initially), but there is nothing intentional here. If you want to discuss further, please raise a ticket with topcoder support and tag me onto the message ([email protected]). Would prefer to move the conversation outside this thread for better accountability. I have a low likelihood of responding within github due to the high volume of tickets we are looking at.