Skip to content

MSFT-124 #2947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 28, 2019
Merged

MSFT-124 #2947

merged 2 commits into from
Jul 28, 2019

Conversation

r0hit-gupta
Copy link
Collaborator

@r0hit-gupta r0hit-gupta commented Jul 18, 2019 •
edited
Loading

Changes for #2822

@r0hit-gupta r0hit-gupta changed the title changes for #2829 MSFT-133 Jul 18, 2019
@r0hit-gupta r0hit-gupta changed the title MSFT-133 MSFT-133 & MSFT-124 Jul 18, 2019
@codeMinter codeMinter self-assigned this Jul 23, 2019
@codeMinter
Copy link
Contributor

codeMinter commented Jul 23, 2019 •
edited
Loading

@sushilshinde NOTE - this is fix for 2 issues.

@sushilshinde
Copy link
Collaborator

@r0hit-gupta @codeMinter please do not follow this practice

I want two separate PRs, I have to track fixes till the production deployment.

@sushilshinde
Copy link
Collaborator

@r0hit-gupta @codeMinter

#2947 (comment)

@codeMinter
Copy link
Contributor

@sushilshinde got it.

@r0hit-gupta can you kindly make 2 PRs, I will close this so we don't merge this.

@codeMinter codeMinter closed this Jul 24, 2019
@r0hit-gupta r0hit-gupta mentioned this pull request Jul 25, 2019
Closed
@veshu
Copy link
Contributor

veshu commented Jul 25, 2019

@codeMinter @sushilshinde The same fix for two issue? please reconfirm. Thanks!

@veshu veshu reopened this Jul 25, 2019
@codeMinter
Copy link
Contributor

#2829 (comment)

@r0hit-gupta r0hit-gupta changed the title MSFT-133 & MSFT-124 MSFT-124 Jul 26, 2019
@r0hit-gupta
Copy link
Collaborator Author

r0hit-gupta commented Jul 26, 2019 •
edited
Loading

@codeMinter I have marked one issue as duplicate. How to proceed?

@sushilshinde sushilshinde merged commit d453343 into topcoder-platform:qa-accessibility Jul 28, 2019
sushilshinde added a commit that referenced this pull request Jul 29, 2019
@sushilshinde
Merge pull request #2947 from r0hit-gupta/msft133
65109a7 
MSFT-124
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajefts ajefts Awaiting requested review from ajefts ajefts is a code owner

@sushilshinde sushilshinde Awaiting requested review from sushilshinde sushilshinde is a code owner

Assignees

@codeMinter codeMinter

Labels
Accessibility Merged for QA
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@r0hit-gupta @codeMinter @sushilshinde @veshu @crazyk07 @agrawal-prateek