Skip to content

MSFT-33 #2938

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 20, 2019
Merged

MSFT-33 #2938

merged 4 commits into from
Jul 20, 2019

Conversation

r0hit-gupta
Copy link
Collaborator

changes for #2755

@vl-ti vl-ti self-assigned this Jul 19, 2019
@vl-ti
Copy link

vl-ti commented Jul 19, 2019

@r0hit-gupta
Good work. Your fix works. But there is a minor issue with coding style. Could you please define number constants in curly brackets, not in double-quotes, to keep the style consistent with the existing code. Thanks!

@sushilshinde sushilshinde merged commit 63cb74e into topcoder-platform:qa-accessibility Jul 20, 2019
sushilshinde added a commit that referenced this pull request Jul 28, 2019
@sushilshinde
Merge pull request #2938 from r0hit-gupta/msft33
e8438a5 
MSFT-33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sushilshinde sushilshinde sushilshinde approved these changes

@ajefts ajefts Awaiting requested review from ajefts ajefts is a code owner

Assignees

@vl-ti vl-ti

Labels
Merged for QA
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@r0hit-gupta @vl-ti @sushilshinde @veshu