Skip to content

MSFT-30 #2932

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 25, 2019
Merged

MSFT-30 #2932

merged 3 commits into from
Jul 25, 2019

Conversation

r0hit-gupta
Copy link
Collaborator

changes for #2752

@r0hit-gupta
Copy link
Collaborator Author

Please retrigger the build. The build failed due to some internal error on Circle CI.

@codeMinter
Copy link
Contributor

@r0hit-gupta please fix failing tests and move change to react-ui.

@r0hit-gupta
Copy link
Collaborator Author

@codeMinter done

@sushilshinde
Copy link
Collaborator

PR id fo react-ui, please link such PRs

@codeMinter
Copy link
Contributor

PR id fo react-ui, please link such PRs

Uses exiting variable so no PR for it.

@sushilshinde
Copy link
Collaborator

@r0hit-gupta when there is not dependency dont label :)

@r0hit-gupta
Copy link
Collaborator Author

@sushilshinde which label are you talking about? I did not add any.

@sushilshinde
Copy link
Collaborator

@sushilshinde which label are you talking about? I did not add any.

Sorry I wanted to tag @codeMinter :)

@sushilshinde
Copy link
Collaborator

@r0hit-gupta @codeMinter can you resolve conflicts

src/shared/components/TopcoderFooter/style.scss

@r0hit-gupta
Copy link
Collaborator Author

@sushilshinde done

@sushilshinde sushilshinde merged commit a1e2f26 into topcoder-platform:qa-accessibility Jul 25, 2019
sushilshinde added a commit that referenced this pull request Jul 26, 2019
sushilshinde added a commit that referenced this pull request Jul 29, 2019
sushilshinde added a commit that referenced this pull request Aug 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants