MSFT-22 #2923
MSFT-22 #2923
Conversation
|
@r0hit-gupta please use react-ui for changes. |
|
@r0hit-gupta Please fix the earliest. |
|
@codeMinter @veshu PR at topcoder-archive/topcoder-platform-topcoder-react-ui-kit#19 resolves the issue. |
|
@r0hit-gupta Please confirm this if we need this PR is needed or w.r.t. topcoder-archive/topcoder-platform-topcoder-react-ui-kit#19 @asadath1395 Please review this. |
|
@veshu this PR is required too. |
|
@r0hit-gupta Is the PR ready for review? if so remove the code review failed label. |
| @@ -28,17 +28,17 @@ $track-radius-4: $corner-radius * 2; | |||
|
|
|||
| &.design, | |||
| &.generic { | |||
| background: $tc-light-blue; | |||
| background: $tc-light-blue-110; | |||
There was a problem hiding this comment.
@r0hit-gupta This doesn't pass WCAG level AA
If we use tc-dark-blue-110 it will pass
| @@ -55,19 +55,19 @@ $track-radius-4: $corner-radius * 2; | |||
|
|
|||
| &.design, | |||
| &.generic { | |||
| color: $tc-light-blue; | |||
| color: $tc-light-blue-110; | |||
There was a problem hiding this comment.
@r0hit-gupta Same here it doesn't meet the ratio
using tc-dark-blue-110 for text meets this.
|
@veshu I have updated the colors. Thanks. |
changes for #2745