Skip to content

MSFT-18 #2921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 26, 2019
Merged

MSFT-18 #2921

merged 2 commits into from
Jul 26, 2019

Conversation

r0hit-gupta
Copy link
Collaborator

changes for #2742

@codeMinter
Copy link
Contributor

@veshu this is not right fix, we need fix in react-ui repo. So marking this as failed

@r0hit-gupta
Copy link
Collaborator Author

@codeMinter do you want me to create a variable in react-ui and then reference it here?

@r0hit-gupta
Copy link
Collaborator Author

@codeMinter done

@veshu
Copy link
Contributor

veshu commented Jul 25, 2019

@codeMinter @r0hit-gupta Is this fixed?

@codeMinter
Copy link
Contributor

@veshu not yet, pending testing on myside. I am going by labels so removed Failed so I know I need to test this. Will flag once tested as Passed.

@veshu
Copy link
Contributor

veshu commented Jul 25, 2019

@r0hit-gupta Please confirm this if we need this PR is needed or w.r.t. topcoder-archive/topcoder-platform-topcoder-react-ui-kit#19

@asadath1395 Please review this.

@r0hit-gupta
Copy link
Collaborator Author

@veshu this PR is still needed.

@veshu veshu assigned codeMinter and unassigned codeMinter Jul 25, 2019
@veshu veshu self-assigned this Jul 26, 2019
@sushilshinde sushilshinde merged commit dbf48e7 into topcoder-platform:qa-accessibility Jul 26, 2019
sushilshinde added a commit that referenced this pull request Jul 28, 2019
sushilshinde added a commit that referenced this pull request Jul 28, 2019
sushilshinde added a commit that referenced this pull request Jul 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants