Skip to content

Fix issues of profile enhancements Part 2 #2628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 15, 2019
Merged

Fix issues of profile enhancements Part 2 #2628

merged 4 commits into from
Jun 15, 2019

Conversation

nauhil
Copy link
Collaborator

@nauhil nauhil commented Jun 15, 2019 •
edited
Loading

  • Update validateDates logic as backend and create common function for validation
  • Update invalid message after clicks submit
  • Show error message when language is duplicate

@gurmeetb Please review it

Update validateDates logic as backend and create common function for …
a5184e9 
…validation

Update invalid message after clicks submit for all setting page
@nauhil nauhil requested a review from codeMinter June 15, 2019 15:36
@codeMinter codeMinter self-assigned this Jun 15, 2019
@codeMinter codeMinter merged commit 514405d into topcoder-platform:feature-profile-enhancements Jun 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codeMinter codeMinter Awaiting requested review from codeMinter

@ajefts ajefts Awaiting requested review from ajefts

@sushilshinde sushilshinde Awaiting requested review from sushilshinde

Assignees

@codeMinter codeMinter

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nauhil @codeMinter