Skip to content

issue 2542 fix #2621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 19, 2019
Merged

issue 2542 fix #2621

merged 4 commits into from
Jun 19, 2019

Conversation

rashmi73
Copy link
Contributor

No description provided.

@rashmi73 rashmi73 mentioned this pull request Jun 13, 2019
Closed
@luizrrodrigues luizrrodrigues requested review from luizrrodrigues and removed request for sushilshinde and ajefts June 13, 2019 22:12
luizrrodrigues
luizrrodrigues requested changes Jun 13, 2019
View reviewed changes
Copy link
Collaborator

@luizrrodrigues luizrrodrigues left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rashmi73 When try access some pages and refresh existing blank screen with this error:
window is not defined

Also need to fix circleci error

@rashmi73
Copy link
Contributor Author

@luizrrodrigues is "match" need to be used of react-router-dom?

but then it would be huge change.

Already tried with "withRouter" HOC but all fields are blank in it, because it takes relative values and Header is not wrapped by any Route Tag.

@luizrrodrigues
Copy link
Collaborator

@rashmi73 Wait, need apply both PR to fix that right?

@luizrrodrigues
Copy link
Collaborator

Deployed both, but not working here.

Working in your local, can you share a video?

@luizrrodrigues luizrrodrigues self-requested a review June 14, 2019 21:29
luizrrodrigues
luizrrodrigues requested changes Jun 14, 2019
View reviewed changes
Copy link
Collaborator

@luizrrodrigues luizrrodrigues left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check feedback here: #2542 (comment)

Also make sure to fix CircleCI errors.

@luizrrodrigues luizrrodrigues self-requested a review June 14, 2019 23:57
luizrrodrigues
luizrrodrigues requested changes Jun 14, 2019
View reviewed changes
Copy link
Collaborator

@luizrrodrigues luizrrodrigues left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check feedback here: #2542 (comment)

Also make sure to fix CircleCI issues

@luizrrodrigues luizrrodrigues self-requested a review June 15, 2019 14:37
luizrrodrigues
luizrrodrigues requested changes Jun 15, 2019
View reviewed changes
Copy link
Collaborator

@luizrrodrigues luizrrodrigues left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check feedback here:
#2542 (comment)

Also please before send new PR fix conflicts and CircleCI issues

@luizrrodrigues luizrrodrigues self-requested a review June 19, 2019 03:12
@luizrrodrigues luizrrodrigues merged commit 47b1c80 into topcoder-platform:feature-new-nav Jun 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luizrrodrigues luizrrodrigues Awaiting requested review from luizrrodrigues

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rashmi73 @luizrrodrigues