Fix Server-side filtering on challenge listings #2339
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nauhil can you please fix the failing tests? |
|
@nauhil can you please fix the failing tests? |
|
Have been fixed and committed yesterday Still failing? |
|
Yes, take a look here https://circleci.com/gh/topcoder-platform/community-app/4485 |
|
it seems community-app does not reference latest topcoder-react-lib, so tests failed |
|
ah, yes, that could be it. Let me update the react lib and trigger the tests again. |
ThomasKranitsas
changed the base branch from
hot-fixes
to
server_side_filtering
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ThomasKranitsas Please review it
FYI
I found that the metadata of challenges from backend response is not stable, demo video https://monosnap.com/file/trhOWwV9OM4ze0z3YnbsVVXtbfOJLe
I've update code for Re-calculate metadata of challenges after fetch challenges, demo video https://monosnap.com/file/3leK5abCP8YTPrfOBCrtsJQC8YVDIl