Skip to content

Fix issue with fetching communities list #1881

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 17, 2019
Merged

Fix issue with fetching communities list #1881

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/shared/containers/SubmissionPage.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ class SubmissionsPageContainer extends React.Component {
// check if challenge belongs to any groups
// and the communitiesList is not up-to-date
// then will load the communitiesList
if (!_.isEmpty(groups) && !communitiesList.loadingUuid
if (!_.isEmpty(groups) && !_.isEmpty(communitiesList.loadingUuid)
&& (Date.now() - communitiesList.timestamp > USER_GROUP_MAXAGE)) {
getCommunitiesList(auth);
}
Expand Down
2 changes: 1 addition & 1 deletion src/shared/containers/challenge-detail/index.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,7 @@ class ChallengeDetailPageContainer extends React.Component {
loadChallengeDetails(auth, challengeId);
}

if (!communitiesList.loadingUuid
if (!_.isEmpty(communitiesList.loadingUuid)
&& (Date.now() - communitiesList.timestamp > USER_GROUP_MAXAGE)) {
getCommunitiesList(auth);
}
Expand Down
2 changes: 1 addition & 1 deletion src/shared/containers/challenge-listing/Listing/index.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ export class ListingContainer extends React.Component {
selectBucket(queryBucket);
}

if (!communitiesList.loadingUuid
if (!_.isEmpty(communitiesList.loadingUuid)
&& (Date.now() - communitiesList.timestamp > USER_GROUP_MAXAGE)) {
getCommunitiesList(auth);
}
Expand Down